Rollup of 10 pull requests #75383
Merged
Rollup of 10 pull requests #75383
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…into transmute module
There are 5 errors, when there should be 7.
…R_CASTS handling after the match The reason I did this in the first place was to try and figure out why I don't see my expected 7 error messages
…that we still get an ICE
…re covering the same ground
…ainst lint ordering changing
…ible_as_ptr_casts test
This seemed to overdo it a bit, affecting multiple submodules, and changing a file I didn't touch, so I didn't commit those changes
Co-authored-by: Philipp Krones <hello@philkrones.com>
This commit fixes an issue with rust-lang#74695 where the fptosi and fptoui specializations on wasm were accidentally used on vector types by the `simd_cast` intrinsic. This issue showed up as broken CI for the stdsimd crate. Here this commit simply skips the specialization on vector kinds flowing into `fpto{s,u}i`.
…d not suggest anything
Previously if the compiler error'd, fatally, then temporary directories which should be preserved by -Csave-temps would be deleted due to fatal compiler errors being implemented as panics.
This commit restricts the substitution polymorphization added in rust-lang#75255 to only apply to the tupled upvar substitution, rather than all substitutions, fixing a bunch of regressions when polymorphization is enabled. Signed-off-by: David Wood <david@davidtw.co>
Fixes rust-lang#75361 Fixes rust-lang#74918 Previously, we were creating a new `InferCtxt`, which caused an ICE when used with type variables from the existing `InferCtxt`
…xperiment, r=oli-obk Clippy pointer cast lint experiment This PR is an experiment about exposing more parts of `rustc_typeck` for use in `clippy`. In particular, the code that checks where a cast is valid or not was exposed, which necessitated exposing [`FnCtxt`](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_typeck/check/struct.FnCtxt.html), and figuring out how to create an instance of that type inside `clippy`. This was prompted by [this clippy issue](rust-lang/rust-clippy#2064). r? @oli-obk
…Manishearth Only add a border for the rust logo    I didn't add a border for the light theme though, as I felt it as unnecessary. r? @Manishearth
…tic-morse Avoid deleting temporary files on error Previously if the compiler error'd, fatally, then temporary directories which should be preserved by -Csave-temps would be deleted due to fatal compiler errors being implemented as panics. cc @infinity0 (Hopefully) fixes rust-lang#75275, but I haven't tested
Don't try to use wasm intrinsics on vectors This commit fixes an issue with rust-lang#74695 where the fptosi and fptoui specializations on wasm were accidentally used on vector types by the `simd_cast` intrinsic. This issue showed up as broken CI for the stdsimd crate. Here this commit simply skips the specialization on vector kinds flowing into `fpto{s,u}i`.
…xes, r=eddyb instance: only polymorphize upvar substs This PR restricts the substitution polymorphization added in rust-lang#75255 to only apply to the tupled upvar substitution, rather than all substitutions, fixing a bunch of regressions when polymorphization is enabled. Due to an oversight on my part, when landing rust-lang#75260 and rust-lang#75255, some tests started failing when polymorphization was enabled that I didn't notice until after landing - this PR fixes the regressions from rust-lang#75255. rust-lang#75336 has been filed to make sure that we don't forget to try make this change again in future, as it does enable some optimisations. r? @lcnr
evaluate required_consts when pushing stack frame in Miri engine [Just like codegen](https://github.com/rust-lang/rust/pull/70820/files#diff-32c57af5c8e23eb048f55d1e955e5cd5R194), Miri needs to make sure all `required_consts` evaluate successfully, to catch post-monomorphization errors. While at it I also moved the const_eval error reporting logic into rustc_mir::const_eval::error; there is no reason it should be in `rustc_middle`. I kept this in a separate commit for easier reviewing. Helps with rust-lang/miri#1382. I will add a test on the Miri side (done now: rust-lang/miri#1504). r? @oli-obk
Use existing `infcx` when emitting trait impl diagnostic Fixes rust-lang#75361 Fixes rust-lang#74918 Previously, we were creating a new `InferCtxt`, which caused an ICE when used with type variables from the existing `InferCtxt`
Add help button Part of rust-lang#75197. Here is a screenshot of the result:  r? @jyn514
…orrow, r=Manishearth Move to intra-doc links in /library/core/src/borrow.rs Helps with rust-lang#75080. @rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc Known issues: * Links from `core` to `std` (rust-lang#74481): * [`Box<T>`] * [`Mutex<T>`] * [`Rc<T>`] * [`String`] * [`HashMap<K, V>`]
…cmp, r=Dylan-DPC Use intra-doc links in /library/core/src/cmp.rs Helps with rust-lang#75080. @rustbot modify labels: T-doc, A-intra-doc-links, T-rustdoc Known issues: * Links from `core` to `std` (rust-lang#74481): * [`Vec::sort_by_key`]
Author
| @bors r+ p=5 rollup=never |
Collaborator
| 📌 Commit 0a738d4 has been approved by |
bors added the S-waiting-on-bors Collaborator
Collaborator
| ☀️ Test successful - checks-actions, checks-azure |
This was referenced Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Successful merges:
infcxwhen emitting trait impl diagnostic #75363 (Use existinginfcxwhen emitting trait impl diagnostic)Failed merges:
r? @ghost