expand: More precise locations for expansion-time lints #73178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive added the S-waiting-on-review 
This was referenced Jun 9, 2020
| @bors r+ |
| 📌 Commit d60df53 has been approved by |
bors added S-waiting-on-bors 
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 12, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#72906 (Migrate to numeric associated consts) - rust-lang#73178 (expand: More precise locations for expansion-time lints) - rust-lang#73225 (Allow inference regions when relating consts) - rust-lang#73236 (Clean up E0666 explanation) - rust-lang#73273 (Fix Zulip pings) Failed merges: r? @ghost
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Nov 18, 2020
stability: More precise location for deprecation lint on macros One missing piece of rust-lang#73178.
m-ou-se added a commit to m-ou-se/rust that referenced this pull request Nov 18, 2020
stability: More precise location for deprecation lint on macros One missing piece of rust-lang#73178.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
First commit: a macro expansion doesn't have a
NodeIdassociated with it, but it has a parentDefIdwhich we can use for linting.The observable effect is that lints associated with macro expansions can now be
allowed at finer-grained level than whole crate.Second commit: each macro definition has a
NodeIdwhich we can use for linting, unless that macro definition was decoded from other crate.