Sort sidebar elements

[GuillaumeGomez]

r? @kinnison

[rust-highfive]

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

##[section]Starting: Linux mingw-check ##[section]Starting: Initialize job Agent name: 'Hosted Agent' Agent machine name: 'fv-az578' Current agent version: '2.168.2' ##[group]Operating System 16.04.6 LTS LTS ##[endgroup] ##[group]Virtual Environment Environment: ubuntu-16.04 Version: 20200517.1 Included Software: https://github.com/actions/virtual-environments/blob/ubuntu16/20200517.1/images/linux/Ubuntu1604-README.md ##[endgroup] Agent running as: 'vsts' Prepare build directory. Set build variables. Download all required tasks. Download all required tasks. Downloading task: Bash (3.163.2) Checking job knob settings. Knob: AgentToolsDirectory = /opt/hostedtoolcache Source: ${AGENT_TOOLSDIRECTORY} Knob: AgentPerflog = /home/vsts/perflog Source: ${VSTS_AGENT_PERFLOG} Start tracking orphan processes. ##[section]Finishing: Initialize job ##[section]Starting: Configure Job Name ============================================================================== --- ========================== Starting Command Output =========================== [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/79383d42-9e59-4396-b598-12ad2793cb58.sh ##[section]Finishing: Disable git automatic line ending conversion ##[section]Starting: Checkout rust-lang/rust@refs/pull/72650/merge to s Task : Get sources Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories. Version : 1.0.0 Author : Microsoft --- ##[command]git remote add origin https://github.com/rust-lang/rust ##[command]git config gc.auto 0 ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader ##[command]git config --get-all http.proxy ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/72650/merge:refs/remotes/pull/72650/merge --- ---> 3adb0605cc65 Step 6/7 : ENV RUN_CHECK_WITH_PARALLEL_QUERIES 1 ---> Using cache ---> 28dbc326cb7f Step 7/7 : ENV SCRIPT python3 ../x.py test src/tools/expand-yaml-anchors && python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu && python3 ../x.py build --stage 0 src/tools/build-manifest && python3 ../x.py test --stage 0 src/tools/compiletest && python3 ../x.py test src/tools/tidy && python3 ../x.py doc --stage 0 src/libstd && /scripts/validate-toolstate.sh ---> 537a01811900 Successfully built 537a01811900 Successfully tagged rust-ci:latest Built container sha256:537a018119009dc218456238dec90b5530050db1e2a1e166550c218003f6159d --- Checking rustc_feature v0.0.0 (/checkout/src/librustc_feature) Checking fmt_macros v0.0.0 (/checkout/src/libfmt_macros) Checking rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty) Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir) Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system) Checking chalk-rust-ir v0.10.0 Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse) Checking rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty) Checking rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering) --- configure: llvm.assertions := True configure: rust.dist-src := False configure: rust.debug-assertions := True configure: build.cargo-native-static := True configure: build.configure-args := ['--enable-sccache', '--disable-manage-submodu ... configure: writing `config.toml` in current directory configure: configure: run `python /checkout/x.py --help` configure: --- Hugepagesize: 2048 kB DirectMap4k: 149440 kB DirectMap2M: 2996224 kB DirectMap1G: 6291456 kB + python3 ../x.py test src/tools/expand-yaml-anchors Ensuring the YAML anchors in the GitHub Actions config were expanded Ensuring the YAML anchors in the GitHub Actions config were expanded Building stage0 tool expand-yaml-anchors (x86_64-unknown-linux-gnu) Compiling unicode-xid v0.2.0 Compiling syn v1.0.11 Compiling linked-hash-map v0.5.2 Compiling lazy_static v1.4.0 Compiling lazy_static v1.4.0 Compiling yaml-rust v0.4.3 Compiling quote v1.0.2 Compiling thiserror-impl v1.0.5 Compiling thiserror v1.0.5 Compiling yaml-merge-keys v0.4.0 Compiling expand-yaml-anchors v0.1.0 (/checkout/src/tools/expand-yaml-anchors) Build completed successfully in 0:00:30 + python3 ../x.py check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu Finished dev [unoptimized] target(s) in 0.22s Checking rustdoc artifacts (x86_64-unknown-linux-gnu -> i686-pc-windows-gnu) --- Checking rustc_feature v0.0.0 (/checkout/src/librustc_feature) Checking fmt_macros v0.0.0 (/checkout/src/libfmt_macros) Checking rustc_ast_pretty v0.0.0 (/checkout/src/librustc_ast_pretty) Checking rustc_hir v0.0.0 (/checkout/src/librustc_hir) Checking chalk-rust-ir v0.10.0 Checking rustc_query_system v0.0.0 (/checkout/src/librustc_query_system) Checking chalk-solve v0.10.0 Checking rustc_hir_pretty v0.0.0 (/checkout/src/librustc_hir_pretty) Checking rustc_parse v0.0.0 (/checkout/src/librustc_parse) Checking rustc_ast_lowering v0.0.0 (/checkout/src/librustc_ast_lowering) --- skip untracked path src/doc/rust-by-example/ during rustfmt invocations skip untracked path src/llvm-project/ during rustfmt invocations Diff in /checkout/src/librustdoc/html/render.rs at line 4371: .iter() .filter(|f| if let clean::StructFieldItem(..) = f.inner { true } else { false }) .filter_map(|f| match f.name { - Some(ref name) => Some(format!( - "<a href=\"#structfield.{name}\">{name}</a>", - name = name - )), + Some(ref name) => { + Some(format!("<a href=\"#structfield.{name}\">{name}</a>", name = name)) _ => None, }) .collect::<Vec<_>>(); Diff in /checkout/src/librustdoc/html/render.rs at line 4408: Diff in /checkout/src/librustdoc/html/render.rs at line 4408: .variants .iter() .filter_map(|v| match v.name { - Some(ref name) => Some(format!( - "<a href=\"#variant.{name}\">{name}</a>", - name = name - )), + Some(ref name) => Some(format!("<a href=\"#variant.{name}\">{name}</a>", name = name)), }) .collect::<Vec<_>>(); .collect::<Vec<_>>(); Running `"/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/rustfmt" "--config-path" "/checkout" "--edition" "2018" "--unstable-features" "--skip-children" "--check" "/checkout/src/librustdoc/html/render.rs"` failed. If you're running `tidy`, try again with `--bless`. Or, if you just want to format code, run `./x.py fmt` instead. Build completed unsuccessfully in 0:00:41 == clock drift check == local time: Wed May 27 10:09:33 UTC 2020 network time: Wed, 27 May 2020 10:09:33 GMT network time: Wed, 27 May 2020 10:09:33 GMT == end clock drift check == ##[error]Bash exited with code '1'. ##[section]Finishing: Run build ##[section]Starting: Checkout rust-lang/rust@refs/pull/72650/merge to s Task : Get sources Description : Get sources from a repository. Supports Git, TfsVC, and SVN repositories. Version : 1.0.0 Author : Microsoft Author : Microsoft Help : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199) ============================================================================== Cleaning any cached credential from repository: rust-lang/rust (GitHub) ##[section]Finishing: Checkout rust-lang/rust@refs/pull/72650/merge to s Cleaning up task key Start cleaning up orphan processes. Terminate orphan process: pid (3809) (python) ##[section]Finishing: Finalize Job 

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

[kinnison]

@bors r+

[bors]

📌 Commit 5ba5b65 has been approved by kinnison