Miri validation error handling cleanup #71950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
…the shorter name)
…ing manual throw_validation_failure sites
rust-highfive added the S-waiting-on-review 
RalfJung commented May 6, 2020
| err_ub!(AlignmentCheckFailed { .. }) => | ||
| { "unaligned vtable pointer in wide pointer" }, | ||
| err_ub!(PointerOutOfBounds { .. }) => | ||
| { "too small vtable" }, |
There was a problem hiding this comment.
With the new macro, giving more precise errors is so easy that I just did it here. :D
| @bors r+ |
| 📌 Commit 0e2a712 has been approved by |
bors added S-waiting-on-bors 
bors added a commit to rust-lang-ci/rust that referenced this pull request May 6, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#70908 (Provide suggestions for type parameters missing bounds for associated types) - rust-lang#71731 (Turn off rustc-dev-guide toolstate for now) - rust-lang#71888 (refactor suggest_traits_to_import) - rust-lang#71918 (Rename methods section) - rust-lang#71950 (Miri validation error handling cleanup) Failed merges: r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Slightly expand @jumbatm's pattern macro and use it throughout validation. This ensures we never incorrectly swallow
InvalidProgramerrors or ICE when they occur.Fixes #71353
r? @oli-obk