Detect errors caused by async block in 2015 edition #71783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive added the S-waiting-on-review | r? @tmandry |
tmandry reviewed May 5, 2020
| Looks good, thanks!! r=me after nit. |
| @bors r=tmandry |
| 📌 Commit 3cf5569 has been approved by |
bors added S-waiting-on-bors Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 7, 2020
Detect errors caused by `async` block in 2015 edition Fix rust-lang#67204.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request May 7, 2020
Detect errors caused by `async` block in 2015 edition Fix rust-lang#67204.
| ⌛ Testing commit 3cf5569 with merge 869761e5f3a94a4004b5b631001030dc3cbef605... |
| 💔 Test failed - checks-actions |
bors added S-waiting-on-review bors added a commit to rust-lang-ci/rust that referenced this pull request May 8, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#70733 (Add Arc::{incr,decr}_strong_count) - rust-lang#71598 (improve Drop documentation) - rust-lang#71783 (Detect errors caused by `async` block in 2015 edition) - rust-lang#71903 (reword "possible candidate" import suggestion) - rust-lang#71960 (Fix E0284 to not use incorrect wording) Failed merges: r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fix #67204.