Impl Error for Infallible #71633
Merged
Impl Error for Infallible #71633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @hanna-kruppe (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive added the S-waiting-on-review | Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
| r? @SimonSapin |
joelpalmer added S-waiting-on-review 
crlf0710 added S-waiting-on-review 
| 📌 Commit ef485c6 has been approved by |
bors added S-waiting-on-bors 
dtolnay added the T-libs JohnTitor added a commit to JohnTitor/rust that referenced this pull request May 28, 2020
Impl Error for Infallible This PR only changes the place where `impl Error for Infallible` is documented, as one could think that it is not the case when reading https://doc.rust-lang.org/nightly/std/convert/enum.Infallible.html. Fixes rust-lang#70842
bors added a commit to rust-lang-ci/rust that referenced this pull request May 29, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#71633 (Impl Error for Infallible) - rust-lang#71843 (Tweak and stabilize AtomicN::fetch_update) - rust-lang#72288 (Stabilization of weak-into-raw) - rust-lang#72324 (Stabilize AtomicN::fetch_min and AtomicN::fetch_max) - rust-lang#72452 (Clarified the documentation for Formatter::precision) - rust-lang#72495 (Improve E0601 explanation) - rust-lang#72534 (Improve missing `@` in slice binding pattern diagnostics) - rust-lang#72547 (Added a codegen test for a recent optimization for overflow-checks=on) - rust-lang#72711 (remove redundant `mk_const`) - rust-lang#72713 (Whitelist #[allow_internal_unstable]) - rust-lang#72720 (Clarify the documentation of `take`) Failed merges: r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR only changes the place where
impl Error for Infallibleis documented, as one could think that it is not the case when reading https://doc.rust-lang.org/nightly/std/convert/enum.Infallible.html.Fixes #70842