Handle build completion message from Cargo #71567
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was introduced in the recent bump to 1.43 bootstrap cargo
| @Mark-Simulacrum: no appropriate reviewer found, use r? to override |
rust-highfive added the S-waiting-on-review | @matthiaskrgr -- want to do a review here? |
| LGTM, can confirm that #71561 no longer occurs, thanks! |
| @bors r=matthiaskrgr |
| 📌 Commit 5a5fa39 has been approved by |
bors added S-waiting-on-bors 
| @Mark-Simulacrum Just so I’m clear, what you’re proposing is including changes to the JSON output in the release notes? That seems fine with me if that’s the case. |
| Yeah, just a brief note that Cargo now prints build completion messages. Doesn't have to be in Rustc release notes either, I just want to make sure we write it down somewhere. |
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 27, 2020
…iaskrgr Handle build completion message from Cargo This was introduced in the recent bump to 1.44 bootstrap cargo Fixes rust-lang#71561.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 28, 2020
…iaskrgr Handle build completion message from Cargo This was introduced in the recent bump to 1.44 bootstrap cargo Fixes rust-lang#71561.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 28, 2020
…iaskrgr Handle build completion message from Cargo This was introduced in the recent bump to 1.44 bootstrap cargo Fixes rust-lang#71561.
Dylan-DPC-zz pushed a commit to Dylan-DPC-zz/rust that referenced this pull request Apr 29, 2020
…iaskrgr Handle build completion message from Cargo This was introduced in the recent bump to 1.44 bootstrap cargo Fixes rust-lang#71561.
RalfJung added a commit to RalfJung/rust that referenced this pull request Apr 30, 2020
…iaskrgr Handle build completion message from Cargo This was introduced in the recent bump to 1.44 bootstrap cargo Fixes rust-lang#71561.
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 30, 2020
Rollup of 8 pull requests Successful merges: - rust-lang#71148 (Vec drop and truncate: drop using raw slice *mut [T]) - rust-lang#71465 (Add a convenience method on `TyCtxt` for checking for thread locals) - rust-lang#71567 (Handle build completion message from Cargo) - rust-lang#71590 (MIR dump: print pointers consistently with Miri output) - rust-lang#71682 (Bump pulldown-cmark) - rust-lang#71688 (Allow `Downcast` projections unconditionally in const-checking) - rust-lang#71691 (Allow `Unreachable` terminators unconditionally in const-checking) - rust-lang#71719 (Update backtrace-sys) Failed merges: r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This was introduced in the recent bump to 1.44 bootstrap cargo
Fixes #71561.