Rollup of 8 pull requests #71539
Merged
Rollup of 8 pull requests #71539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This solves the method call part of issue rust-lang#69455 I added a `target_span` field so as to pin down the exact location of the error. We need a dedicated field `found_exact_method_call` to prioritize situations like the test case `issue-69455.rs`. If we reuse `found_method_call`, `found_local_pattern` will show up first. We can not move `found_method_call` up, it is undesirable in various situations.
This was needed by an early version of dataflow-based const qualification where `QualifCursor` needed to return a full `BitSet` with the current state.
Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
These are changes that would be needed if we add `#[must_use]` to `Option::map`, per rust-lang#71484.
…or, r=estebank fix misleading type annotation diagonstics This solves the method call part of issue rust-lang#69455
…=oli-obk Only run dataflow for const qualification if type-based check would fail This is the optimization discussed in rust-lang#49146 (comment). We wait for `Qualif::in_any_value_of_ty` to return `true` before running dataflow. For bodies that deal mostly with primitive types, this will avoid running dataflow at all during const qualification. This also removes the `BitSet` used to cache `in_any_value_of_ty` for each local, which was only necessary for an old version of rust-lang#64470 that also handled promotability.
…r=Dylan-DPC Improve PanicInfo examples readability cc @Eijebong r? @Dylan-DPC
…manieu Add BinaryHeap::retain as suggested in rust-lang#42849 This PR implements retain for BinaryHeap as suggested in rust-lang#42849. This is my first PR for Rust, so please let me know if I should be doing anything differently, thanks!
…r=Mark-Simulacrum Remove useless "" args Signed-off-by: Rustin-Liu <rustin.liu@gmail.com>
…r=Dylan-DPC Miscellaneous cleanup in `check_consts` Just changes `RUSTC_LOG` output.
…imulacrum Avoid unused Option::map results These are changes that would be needed if we add `#[must_use]` to `Option::map`, per rust-lang#71484. r? @Mark-Simulacrum
…, r=Mark-Simulacrum Fix typos in docs for keyword "in" Erroneous .md formatting was causing the link to not work on the currently-nightly keyword docs for `in`, and also there was a simple typo.
| @bors r+ p=8 rollup=never |
| 📌 Commit 32fb77d has been approved by |
bors added the S-waiting-on-bors | ☀️ Test successful - checks-azure |
This was referenced Apr 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Successful merges:
check_consts#71527 (Miscellaneous cleanup incheck_consts)Failed merges:
r? @ghost