Rollup of 9 pull requests #70994
Merged
Rollup of 9 pull requests #70994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Keep more information about trait binding failures.
…=nikomatsakis,eddyb Use `PredicateObligation`s instead of `Predicate`s Keep more information about trait binding failures. Use more specific spans by pointing at bindings that introduce obligations. Subset of rust-lang#69709. r? @eddyb
…ruppe Add ThreadSanitizer test case
…nas-schievink Use forward traversal for unconditional recursion lint While reviewing rust-lang#70822, I noted that rust-lang#54444 could be solved without requiring the predecessor graph and without allocating a `Vec<Span>` for every basic block. The unconditional recursion lint is not a performance bottleneck however, so I approved rust-lang#70822 as it was. Nevertheless, I wanted to try implementing my idea using `TriColorDepthFirstSearch`, which is a DFS that can differentiate between [forward/tree edges and backward ones](https://en.wikipedia.org/wiki/Depth-first_search#Output_of_a_depth-first_search). I found this approach more straightforward than the existing one, so I'm opening this PR to see if it is desirable. The pass is now just a DFS across the control-flow graph. We ignore false edges and false unwinds, as well as the successors of recursive calls, just like existing pass does. If we see a back-edge (loop) or a terminator that would cause us to yield control-flow back to the caller (`Return`, `Resume`, etc.), we know that the function does not unconditionally recurse. r? @jonas-schievink
…Simulacrum compiletest: let config flags overwrite -A unused Cc Manishearth/compiletest-rs#216
…ariations, r=Amanieu Follow up on BTreeMap comments r? @Amanieu (for the first commit)
…Mark-Simulacrum Rearrange BTreeMap::into_iter to match range_mut. r? @Mark-Simulacrum I wondered why you catered for the optional root differently in `into_iter` than in `range_mut`.
…an-DPC Clean up E0512 explanation r? @Dylan-DPC
…e, r=Mark-Simulacrum Setup the `@rustbot prioritize` command See rust-lang/triagebot#453 r? @Mark-Simulacrum can you confirm that the `t-compiler/wg-prioritization` stream ID is `227806`? cc @spastorino
fix rustc-dev-guide's url in src/librustc_codegen_ssa Change the backend-agnostic chapter's url in rustc-dev-guide from [url](https://rustc-dev-guide.rust-lang.org/codegen/backend-agnostic.html), which is 404 now, to [the right one](https://rustc-dev-guide.rust-lang.org/backend/backend-agnostic.html). Sorry for disturbing.
Contributor Author
| @bors r+ p=9 rollup=never |
Collaborator
| 📌 Commit 178aa6a has been approved by |
bors added the S-waiting-on-bors Collaborator
Collaborator
| ☀️ Test successful - checks-azure |
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Successful merges:
PredicateObligations instead ofPredicates #69745 (UsePredicateObligations instead ofPredicates)@rustbot prioritizecommand #70988 (Setup the@rustbot prioritizecommand)Failed merges:
r? @ghost