avoid creating unnecessary reference in Windows Env iterator #70479
+1 −1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| r? @shepmaster (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive added the S-waiting-on-review This was referenced Mar 27, 2020
| @bors r+ rollup |
| 📌 Commit 2a1e61e has been approved by |
bors added S-waiting-on-bors | ⌛ Testing commit 2a1e61e with merge 436b6e93f2f9d171a1dcbec015ea57e3a5023b05... |
| @bors retry (yield) |
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 30, 2020
Rollup of 4 pull requests Successful merges: - rust-lang#70479 (avoid creating unnecessary reference in Windows Env iterator) - rust-lang#70546 (Polonius: update to 0.12.1, fix more move errors false positives, update test expectations) - rust-lang#70559 (fix BTreeMap test compilation with Miri) - rust-lang#70567 (Fix broken link in README) Failed merges: r? @ghost
JOE1994 added a commit to JOE1994/miri that referenced this pull request Jun 8, 2020
A small fix was made to libstd in rust-lang/rust#70479 (back in March). (Miri reported UB due to Stacked Borrows violation - [link to Miri error log](rust-lang#1225 (comment))) Thank you for reviewing 👍
bors added a commit to rust-lang/miri that referenced this pull request Jun 8, 2020
Add a case to list of 'StackedBorrows violations' A small fix was made to libstd in rust-lang/rust#70479 (back in March). (Miri reported UB due to Stacked Borrows violation - [link to Miri error log](#1225 (comment))) Thank you for reviewing 👍
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Discovered in rust-lang/miri#1225: the Windows
Enviterator violates Stacked Borrows by creating an&u16, turning it into a raw pointer, and then accessing memory outside the range of that type.There is no need to create a reference here in the first place, so the fix is trivial.
Cc @JOE1994
Cc rust-lang/unsafe-code-guidelines#134