Skip to content

Upgrade GCC to 8.3.0, glibc to 2.17.0 and crosstool-ng to 1.24.0 for dist-arm-linux and dist-armhf-linux #70414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 1, 2020
Merged

Upgrade GCC to 8.3.0, glibc to 2.17.0 and crosstool-ng to 1.24.0 for dist-arm-linux and dist-armhf-linux #70414

merged 2 commits into from
Apr 1, 2020

Conversation

lopsided98
Copy link
Contributor

Attempt to fix #69420 in the same manner as #65302 did for armv7l. I have tested that this eliminates the segfault while building a hello_world package on arm-unknown-linux-gnueabihf.

I have not been able to test whether the bug exists for arm-unknown-linux-gnueabi as well, but I suspect it does, so I upgraded the toolchain for that platform as well.
@rust-highfive
Copy link
Contributor

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pietroalbini (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 26, 2020
@lopsided98 lopsided98 mentioned this pull request Mar 26, 2020
Closed
@pietroalbini
Copy link
Member

Thanks for this PR!

Could you remove the duplication of the crosstool-ng installation script? Moving a copy of it to scripts/crosstool-ng-1.24.sh and removing the existing copies would do the trick.
@lopsided98
Copy link
Contributor Author

Done.
@pietroalbini
Copy link
Member

Thanks for the PR!

@bors r+ rollup=never
@bors
Copy link
Collaborator

bors commented Mar 31, 2020

📌 Commit 55bdb61 has been approved by pietroalbini
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 31, 2020
@Dylan-DPC-zz
Copy link

@bors p=1
@bors
Copy link
Collaborator

bors commented Mar 31, 2020

⌛ Testing commit 55bdb61 with merge 4e4a6403cf67462a2633da2a1889b8e0872d0e6e...
@Dylan-DPC-zz
Copy link

@bors retry (yield)
@bors
Copy link
Collaborator

bors commented Apr 1, 2020

⌛ Testing commit 55bdb61 with merge 1a87c49...
@bors
Copy link
Collaborator

bors commented Apr 1, 2020

☀️ Test successful - checks-azure
Approved by: pietroalbini
Pushing 1a87c49 to master...
@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 1, 2020
@bors bors merged commit 1a87c49 into rust-lang:master Apr 1, 2020
@lopsided98 lopsided98 deleted the armv6-gcc-8 branch April 3, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

5 participants

@lopsided98 @rust-highfive @pietroalbini @bors @Dylan-DPC-zz