Move some build-pass tests to check-pass #69460
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rust-highfive added the S-waiting-on-review 
| cc @rust-lang/wg-const-eval since there are a lot of const related tests here |
| The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
LeSeulArtichaut force-pushed the move-compile-pass branch from 8f81959 to c2b3808 Compare 
| Let's re-assigning someone from wg-const-eval... |
| @wesleywiser @oli-obk does const_prop run in check-pass? |
| As far as I know, all things const-eval happen even for check builds, so everything in But for |
|
|
| Maybe we should split the PR into e.g. const parts, rustdoc-ui parts, and then the various experts can review. |
Yes, it should. |
| ☔ The latest upstream changes (presumably #69914) made this pull request unmergeable. Please resolve the merge conflicts. |
| Leaving one part of the tests in this PR is fine. Feel free to force-push for that. |
LeSeulArtichaut force-pushed the move-compile-pass branch from c2b3808 to 7326e53 Compare | Done! |
RalfJung reviewed Mar 12, 2020
| Thanks! @bors r+ |
| 📌 Commit 8f0fa24 has been approved by |
bors added S-waiting-on-bors | @bors rollup |
Centril added a commit to Centril/rust that referenced this pull request Mar 12, 2020
…r=RalfJung Move some `build-pass` tests to `check-pass` Helps with rust-lang#62277. r? @cramertj cc @Centril
bors added a commit that referenced this pull request Mar 13, 2020
Rollup of 8 pull requests Successful merges: - #68746 (Make macro metavars respect (non-)hygiene) - #69189 (Erase regions in writeback) - #69402 (Extend search) - #69403 (Implement `Copy` for `IoSlice`) - #69460 (Move some `build-pass` tests to `check-pass`) - #69802 (fix more clippy findings) - #69809 (remove lifetimes that can be elided (clippy::needless_lifetimes)) - #69949 (triagebot.toml: add ping aliases) Failed merges: - #69589 (ast: `Mac`/`Macro` -> `MacCall`) r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Mar 13, 2020
…r=RalfJung Move some `build-pass` tests to `check-pass` Helps with rust-lang#62277. r? @cramertj cc @Centril
bors added a commit that referenced this pull request Mar 13, 2020
Rollup of 12 pull requests Successful merges: - #69403 (Implement `Copy` for `IoSlice`) - #69460 (Move some `build-pass` tests to `check-pass`) - #69723 (Added doc on keyword Pub.) - #69802 (fix more clippy findings) - #69809 (remove lifetimes that can be elided (clippy::needless_lifetimes)) - #69947 (Clean up E0423 explanation) - #69949 (triagebot.toml: add ping aliases) - #69954 (rename panic_if_ intrinsics to assert_) - #69960 (miri engine: fix treatment of abort intrinsic) - #69966 (Add more regression tests) - #69973 (Update stable-since version for const_int_conversion) - #69974 (Clean up E0434 explanation) Failed merges: r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Helps with #62277.
r? @cramertj cc @Centril