Make error and warning annotations mandatory in UI tests #66213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive added the S-waiting-on-review | The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
tmiasko force-pushed the mandatory-error-warn branch from 04519ce to 3b3600a Compare | The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
tmiasko force-pushed the mandatory-error-warn branch 2 times, most recently from dc6118c to d989031 Compare 
petrochenkov reviewed Nov 9, 2019
petrochenkov added S-waiting-on-author tmiasko force-pushed the mandatory-error-warn branch from d989031 to 5d28b23 Compare | Rebased and amended commits with suggestions. |
| Thanks! |
| 📌 Commit 5d28b23b51054a4aae39f82bcc8b0bb38deaddcf has been approved by |
bors added S-waiting-on-bors | ☔ The latest upstream changes (presumably #66070) made this pull request unmergeable. Please resolve the merge conflicts. |
bors added S-waiting-on-author This change makes error and warning annotations mandatory in UI tests. The only exception are tests that use error patterns to match compiler output and don't have any annotations.
tmiasko force-pushed the mandatory-error-warn branch from 5d28b23 to 427952e Compare | Rebased. |
| @bors r+ |
| 📌 Commit 427952e has been approved by |
bors added S-waiting-on-bors bors added a commit that referenced this pull request Nov 11, 2019
Make error and warning annotations mandatory in UI tests This change makes error and warning annotations mandatory in UI tests. The only exception are tests that use error patterns to match compiler output and don't have any annotations. Fixes #55596.
| ☀️ Test successful - checks-azure |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This change makes error and warning annotations mandatory in UI tests.
The only exception are tests that use error patterns to match compiler
output and don't have any annotations.
Fixes #55596.