Add option to disable keyboard shortcuts in docs #65656
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
JohnTitor added the S-waiting-on-review 
Manishearth approved these changes Oct 21, 2019
| @bors: r+ rollup |
| 📌 Commit 8774484 has been approved by |
bors added S-waiting-on-bors JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 22, 2019
…cut, r=Dylan-DPC Add option to disable keyboard shortcuts in docs Fixes rust-lang#65211. r? @Manishearth
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Oct 23, 2019
…cut, r=Dylan-DPC Add option to disable keyboard shortcuts in docs Fixes rust-lang#65211. r? @Manishearth
bors added a commit that referenced this pull request Oct 23, 2019
Rollup of 14 pull requests Successful merges: - #64145 (Target-feature documented as unsafe) - #65007 (Mention keyword closing policy) - #65417 (Add more coherence tests) - #65507 (Fix test style in unused parentheses lint test) - #65591 (Add long error explanation for E0588) - #65617 (Fix WASI sleep impl) - #65656 (Add option to disable keyboard shortcuts in docs) - #65678 (Add long error explanation for E0728) - #65681 (Code cleanups following up on #65576.) - #65686 (refactor and move `maybe_append` ) - #65688 (Add some tests for fixed ICEs) - #65689 (bring back some Debug instances for Miri) - #65695 (self-profiling: Remove module names from some event-ids in codegen backend.) - #65706 (Add missing space in librustdoc) Failed merges: r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Oct 25, 2019
…-feature, r=Dylan-DPC Fix default "disable-shortcuts" feature value Follow-up of rust-lang#65656 It fixes the bad handling of the default value of the feature (which would disable shortcut by default, which is bad!). r? @Dylan-DPC cc @kinnison
Centril added a commit to Centril/rust that referenced this pull request Oct 25, 2019
…-feature, r=Dylan-DPC Fix default "disable-shortcuts" feature value Follow-up of rust-lang#65656 It fixes the bad handling of the default value of the feature (which would disable shortcut by default, which is bad!). r? @Dylan-DPC cc @kinnison
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #65211.
r? @Manishearth