Skip to content

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Sep 27, 2019

Successful merges:

Failed merges:

r? @ghost

Nashenas88 and others added 30 commits August 27, 2019 00:20
Following up on [1] and [2], this PR adds differntiation for aarch64 bare-metal targets between versions with and without hardware floating point enabled. This streamlines the target naming with other existing ARM targets and provides the user clear indication if he is getting float or non-float for his bare-metal target. [1] rust-lang#60135 (comment) [2] rust-embedded/wg#230 Closes: rust-embedded/wg#230
New Exprs generated as part of the format macro expansion should get the macro expansion span which has an expansion context, not the span of the format string which does not.
When there's a type mismatch we make an effort to check if it was caused by a function's return type. This logic now makes sure to only point at the return type if the error happens in a tail expression.
This can cause cycles as `ConstProp` uses `layout_of` which, for generators, uses `optimized_mir` which runs `ConstProp`.
This allows us to avoid changing things directly in the miri engine just for const prop.
JMS55 and others added 16 commits September 26, 2019 11:19
update rtpSpawn's parameters type(It's prototype has been updated in …
When the panic handler is run, the existing Handler may be in a weird state if it was responsible for triggering the panic. By using a freshly created Handler, we avoid trying to re-entrantly lock a HandlerInner, which was causing a double panic on ICEs.
…meGomez Fix ICE in rustdoc when merging generic and where bounds of an Fn with an output Fixes rust-lang#57180
…li-obk Deduplicate some code between miri and const prop r? @oli-obk
…e-tests, r=nikomatsakis Bugfix/rfc 2451 rerebalance tests r? @nikomatsakis Fixes rust-lang#64412 Depends/Contains on rust-lang#64414 cc rust-lang#55437 and rust-lang#63599
…=Amanieu Differentiate AArch64 bare-metal targets between hf and non-hf. CC @parched, kindly request you to review. ~~Note: This change breaks code that uses the target `aarch64-unknown-none` for the sake of clearer naming as discussed in the links posted below. A search on github reveals that code using `aarch64-unknown-none` is almost exclusively forked from our embedded WG's OS tutorials repo at https://github.com/rust-embedded/rust-raspi3-OS-tutorials, for which the target was originally created.~~ ~~I will adapt this repo to the new target name asap once this PR would go upstream. The minor annoyance for the forks to break temporarily should be acceptable for the sake of introducing a better differentiation now before it is too late. Also, the break would only happen upon updating the toolchain, giving the user a good hint at what has happened.~~ ---------- Patch commit message: Following up on [1] and [2], this PR adds differntiation for aarch64 bare-metal targets between versions with and without floating point enabled. This streamlines the target naming with other existing ARM targets and provides the user clear indication if he is getting float or non-float for his bare-metal target. [1] rust-lang#60135 (comment) [2] rust-embedded/wg#230 Closes: rust-embedded/wg#230
…varkor Include message on tests that should panic but do not As per issue rust-lang#60790 includes a message for tests marked `#[should_panic]` that do not panic as expected. Fixes rust-lang#60790.
Fix format macro expansions spans to be macro-generated New Exprs generated as part of the format macro expansion should get the macro expansion span with an expansion context, rather than the span of the format string which does not.
…Simulacrum Fix double panic when printing query stack during an ICE On the latest nightly, any call to `bug` or `span_bug` will result in two panics - the first one as a normal result of calling `bug` / `span_bug`, and the second as a result of trying to print the query stack from the panic handler. This is caused by the query-printing code attempting to acquire a lock on `HandlerInnder`, which is still being held by `bug`. This PR moves the actual panic out of `HandlerInner`, into `Handler`. This allows us to release the lock on `HandlerInner` before triggering the panic, ensuring that the panic handler will be able to acquire the lock if necessary.
…atthewjasper Account for tail expressions when pointing at return type When there's a type mismatch we make an effort to check if it was caused by a function's return type. This logic now makes sure to only point at the return type if the error happens in a tail expression. Turn `walk_parent_nodes` method into an iterator. CC rust-lang#39968, CC rust-lang#40799.
Fix div_duration() marked as stable by mistake
update rtpSpawn's parameters type(It's prototype has been updated in libc) r? @alexcrichton
@Centril
Copy link
Contributor Author

Centril commented Sep 27, 2019

@bors r+ p=10 rollup=never

@bors
Copy link
Collaborator

bors commented Sep 27, 2019

📌 Commit 51f7b2b has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Sep 27, 2019
@bors
Copy link
Collaborator

bors commented Sep 27, 2019

⌛ Testing commit 51f7b2b with merge 85e354bbb1687668d2bdb2c2ed654ec9bf40e3a6...

@bors
Copy link
Collaborator

bors commented Sep 27, 2019

💔 Test failed - checks-azure

@rust-highfive
Copy link
Contributor

The job i686-gnu-nopt of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
2019-09-27T05:58:40.2231833Z 7 note: lint level defined here 2019-09-27T05:58:40.2232399Z - --> $DIR/lint-exceeding-bitshifts.rs:1:9 2019-09-27T05:58:40.2232786Z + --> $DIR/lint-exceeding-bitshifts.rs:1:30 2019-09-27T05:58:40.2232883Z 9 | 2019-09-27T05:58:40.2232984Z 10 LL | #![deny(exceeding_bitshifts, const_err)] 2019-09-27T05:58:40.2233475Z + | ^^^^^^^^^ 2019-09-27T05:58:40.2233560Z 12 2019-09-27T05:58:40.2233560Z 12 2019-09-27T05:58:40.2233670Z 13 error: attempt to shift left with overflow 2019-09-27T05:58:40.2234113Z 2019-09-27T05:58:40.2234193Z 101 | ^^^^^^^^^^ 2019-09-27T05:58:40.2234299Z 102 2019-09-27T05:58:40.2234299Z 102 2019-09-27T05:58:40.2234383Z 103 error: attempt to shift left with overflow 2019-09-27T05:58:40.2235131Z - | 2019-09-27T05:58:40.2235131Z - | 2019-09-27T05:58:40.2235460Z - LL | let n = n << 8; 2019-09-27T05:58:40.2236116Z - 2019-09-27T05:58:40.2236116Z - 2019-09-27T05:58:40.2236482Z - error: attempt to shift left with overflow 2019-09-27T05:58:40.2236973Z 111 | 2019-09-27T05:58:40.2236973Z 111 | 2019-09-27T05:58:40.2237304Z 112 LL | let n = 1u8 << -8; 2019-09-27T05:58:40.2238026Z 113 | ^^^^^^^^^ 2019-09-27T05:58:40.2238173Z 114 2019-09-27T05:58:40.2238607Z - error: aborting due to 18 previous errors 2019-09-27T05:58:40.2238746Z + error: aborting due to 17 previous errors 2019-09-27T05:58:40.2238746Z + error: aborting due to 17 previous errors 2019-09-27T05:58:40.2238831Z 116 2019-09-27T05:58:40.2238922Z 117 2019-09-27T05:58:40.2238968Z 2019-09-27T05:58:40.2239026Z 2019-09-27T05:58:40.2239109Z The actual stderr differed from the expected stderr. 2019-09-27T05:58:40.2239613Z Actual stderr saved to /checkout/obj/build/i686-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts/lint-exceeding-bitshifts.stderr 2019-09-27T05:58:40.2240025Z To update references, rerun the tests and pass the `--bless` flag 2019-09-27T05:58:40.2240468Z To only update this specific test, also pass `--test-args lint/lint-exceeding-bitshifts.rs` 2019-09-27T05:58:40.2242140Z error: 1 errors occurred comparing output. 2019-09-27T05:58:40.2242241Z status: exit code: 1 2019-09-27T05:58:40.2242241Z status: exit code: 1 2019-09-27T05:58:40.2243468Z command: "/checkout/obj/build/i686-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/lint-exceeding-bitshifts.rs" "-Zthreads=1" "--target=i686-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/i686-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts" "-Crpath" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts/auxiliary" "-A" "unused" 2019-09-27T05:58:40.2244176Z ------------------------------------------ 2019-09-27T05:58:40.2244245Z 2019-09-27T05:58:40.2244589Z ------------------------------------------ 2019-09-27T05:58:40.2244682Z stderr: 2019-09-27T05:58:40.2244682Z stderr: 2019-09-27T05:58:40.2245014Z ------------------------------------------ 2019-09-27T05:58:40.2245111Z error: attempt to shift left with overflow 2019-09-27T05:58:40.2245610Z | 2019-09-27T05:58:40.2245610Z | 2019-09-27T05:58:40.2245724Z LL | let n = 1u8 << 8; //~ ERROR: attempt to shift left with overflow 2019-09-27T05:58:40.2246217Z | 2019-09-27T05:58:40.2246313Z note: lint level defined here 2019-09-27T05:58:40.2246733Z --> /checkout/src/test/ui/lint/lint-exceeding-bitshifts.rs:1:30 2019-09-27T05:58:40.2246860Z | 2019-09-27T05:58:40.2246860Z | 2019-09-27T05:58:40.2246940Z LL | #![deny(exceeding_bitshifts, const_err)] 2019-09-27T05:58:40.2247109Z 2019-09-27T05:58:40.2247109Z 2019-09-27T05:58:40.2247201Z error: attempt to shift left with overflow 2019-09-27T05:58:40.2247689Z | 2019-09-27T05:58:40.2247689Z | 2019-09-27T05:58:40.2248038Z LL | let n = 1u16 << 16; //~ ERROR: attempt to shift left with overflow 2019-09-27T05:58:40.2248243Z 2019-09-27T05:58:40.2248243Z 2019-09-27T05:58:40.2248336Z error: attempt to shift left with overflow 2019-09-27T05:58:40.2248931Z | 2019-09-27T05:58:40.2248931Z | 2019-09-27T05:58:40.2249021Z LL | let n = 1u32 << 32; //~ ERROR: attempt to shift left with overflow 2019-09-27T05:58:40.2249190Z 2019-09-27T05:58:40.2249190Z 2019-09-27T05:58:40.2249283Z error: attempt to shift left with overflow 2019-09-27T05:58:40.2249789Z | 2019-09-27T05:58:40.2249789Z | 2019-09-27T05:58:40.2249901Z LL | let n = 1u64 << 64; //~ ERROR: attempt to shift left with overflow 2019-09-27T05:58:40.2250054Z 2019-09-27T05:58:40.2250054Z 2019-09-27T05:58:40.2250148Z error: attempt to shift left with overflow 2019-09-27T05:58:40.2250631Z | 2019-09-27T05:58:40.2250631Z | 2019-09-27T05:58:40.2250737Z LL | let n = 1i8 << 8; //~ ERROR: attempt to shift left with overflow 2019-09-27T05:58:40.2251115Z 2019-09-27T05:58:40.2251115Z 2019-09-27T05:58:40.2251202Z error: attempt to shift left with overflow 2019-09-27T05:58:40.2251740Z | 2019-09-27T05:58:40.2251740Z | 2019-09-27T05:58:40.2251849Z LL | let n = 1i16 << 16; //~ ERROR: attempt to shift left with overflow 2019-09-27T05:58:40.2252018Z 2019-09-27T05:58:40.2252018Z 2019-09-27T05:58:40.2252093Z error: attempt to shift left with overflow 2019-09-27T05:58:40.2252577Z | 2019-09-27T05:58:40.2252577Z | 2019-09-27T05:58:40.2252688Z LL | let n = 1i32 << 32; //~ ERROR: attempt to shift left with overflow 2019-09-27T05:58:40.2252856Z 2019-09-27T05:58:40.2252856Z 2019-09-27T05:58:40.2252931Z error: attempt to shift left with overflow 2019-09-27T05:58:40.2253434Z | 2019-09-27T05:58:40.2253434Z | 2019-09-27T05:58:40.2253557Z LL | let n = 1i64 << 64; //~ ERROR: attempt to shift left with overflow 2019-09-27T05:58:40.2253727Z 2019-09-27T05:58:40.2253727Z 2019-09-27T05:58:40.2253929Z error: attempt to shift right with overflow 2019-09-27T05:58:40.2254444Z | 2019-09-27T05:58:40.2254444Z | 2019-09-27T05:58:40.2254534Z LL | let n = 1u8 >> 8; //~ ERROR: attempt to shift right with overflow 2019-09-27T05:58:40.2254705Z 2019-09-27T05:58:40.2254705Z 2019-09-27T05:58:40.2254801Z error: attempt to shift right with overflow 2019-09-27T05:58:40.2255284Z | 2019-09-27T05:58:40.2255284Z | 2019-09-27T05:58:40.2255390Z LL | let n = 1u16 >> 16; //~ ERROR: attempt to shift right with overflow 2019-09-27T05:58:40.2255559Z 2019-09-27T05:58:40.2255559Z 2019-09-27T05:58:40.2255653Z error: attempt to shift right with overflow 2019-09-27T05:58:40.2256319Z | 2019-09-27T05:58:40.2256319Z | 2019-09-27T05:58:40.2256429Z LL | let n = 1u32 >> 32; //~ ERROR: attempt to shift right with overflow 2019-09-27T05:58:40.2256598Z 2019-09-27T05:58:40.2256598Z 2019-09-27T05:58:40.2256676Z error: attempt to shift right with overflow 2019-09-27T05:58:40.2257204Z | 2019-09-27T05:58:40.2257204Z | 2019-09-27T05:58:40.2257314Z LL | let n = 1u64 >> 64; //~ ERROR: attempt to shift right with overflow 2019-09-27T05:58:40.2257483Z 2019-09-27T05:58:40.2257483Z 2019-09-27T05:58:40.2257560Z error: attempt to shift right with overflow 2019-09-27T05:58:40.2258386Z | 2019-09-27T05:58:40.2258386Z | 2019-09-27T05:58:40.2258505Z LL | let n = 1i8 >> 8; //~ ERROR: attempt to shift right with overflow 2019-09-27T05:58:40.2258675Z 2019-09-27T05:58:40.2258675Z 2019-09-27T05:58:40.2258753Z error: attempt to shift right with overflow 2019-09-27T05:58:40.2259250Z | 2019-09-27T05:58:40.2259250Z | 2019-09-27T05:58:40.2259361Z LL | let n = 1i16 >> 16; //~ ERROR: attempt to shift right with overflow 2019-09-27T05:58:40.2259532Z 2019-09-27T05:58:40.2259532Z 2019-09-27T05:58:40.2259609Z error: attempt to shift right with overflow 2019-09-27T05:58:40.2260093Z | 2019-09-27T05:58:40.2260093Z | 2019-09-27T05:58:40.2260204Z LL | let n = 1i32 >> 32; //~ ERROR: attempt to shift right with overflow 2019-09-27T05:58:40.2260566Z 2019-09-27T05:58:40.2260566Z 2019-09-27T05:58:40.2260644Z error: attempt to shift right with overflow 2019-09-27T05:58:40.2261214Z | 2019-09-27T05:58:40.2261214Z | 2019-09-27T05:58:40.2261305Z LL | let n = 1i64 >> 64; //~ ERROR: attempt to shift right with overflow 2019-09-27T05:58:40.2261476Z 2019-09-27T05:58:40.2261476Z 2019-09-27T05:58:40.2261568Z error: attempt to shift left with overflow 2019-09-27T05:58:40.2262057Z | 2019-09-27T05:58:40.2262057Z | 2019-09-27T05:58:40.2262421Z LL | let n = 1u8 << -8; //~ ERROR: attempt to shift left with overflow 2019-09-27T05:58:40.2262602Z 2019-09-27T05:58:40.2262694Z error: aborting due to 17 previous errors 2019-09-27T05:58:40.2262750Z 2019-09-27T05:58:40.2262792Z --- 2019-09-27T05:58:40.2264062Z 7 note: lint level defined here 2019-09-27T05:58:40.2264412Z - --> $DIR/lint-exceeding-bitshifts2.rs:1:9 2019-09-27T05:58:40.2264780Z + --> $DIR/lint-exceeding-bitshifts2.rs:1:30 2019-09-27T05:58:40.2264874Z 9 | 2019-09-27T05:58:40.2264972Z 10 LL | #![deny(exceeding_bitshifts, const_err)] 2019-09-27T05:58:40.2265414Z + | ^^^^^^^^^ 2019-09-27T05:58:40.2265499Z 12 2019-09-27T05:58:40.2265499Z 12 2019-09-27T05:58:40.2265596Z 13 error: attempt to shift left with overflow 2019-09-27T05:58:40.2266030Z 2019-09-27T05:58:40.2266084Z 2019-09-27T05:58:40.2266186Z The actual stderr differed from the expected stderr. 2019-09-27T05:58:40.2266793Z Actual stderr saved to /checkout/obj/build/i686-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts2/lint-exceeding-bitshifts2.stderr 2019-09-27T05:58:40.2266793Z Actual stderr saved to /checkout/obj/build/i686-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts2/lint-exceeding-bitshifts2.stderr 2019-09-27T05:58:40.2267287Z To update references, rerun the tests and pass the `--bless` flag 2019-09-27T05:58:40.2267719Z To only update this specific test, also pass `--test-args lint/lint-exceeding-bitshifts2.rs` 2019-09-27T05:58:40.2268279Z error: 1 errors occurred comparing output. 2019-09-27T05:58:40.2268390Z status: exit code: 1 2019-09-27T05:58:40.2268390Z status: exit code: 1 2019-09-27T05:58:40.2270841Z command: "/checkout/obj/build/i686-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/lint/lint-exceeding-bitshifts2.rs" "-Zthreads=1" "--target=i686-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/i686-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts2" "-Crpath" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-L" "/checkout/obj/build/i686-unknown-linux-gnu/test/ui/lint/lint-exceeding-bitshifts2/auxiliary" "-A" "unused" 2019-09-27T05:58:40.2271548Z ------------------------------------------ 2019-09-27T05:58:40.2271618Z 2019-09-27T05:58:40.2271967Z ------------------------------------------ 2019-09-27T05:58:40.2272082Z stderr: 2019-09-27T05:58:40.2272082Z stderr: 2019-09-27T05:58:40.2272398Z ------------------------------------------ 2019-09-27T05:58:40.2272514Z error: attempt to shift left with overflow 2019-09-27T05:58:40.2273002Z | 2019-09-27T05:58:40.2273002Z | 2019-09-27T05:58:40.2273097Z LL | let n = 1u8 << (4+4); //~ ERROR: attempt to shift left with overflow 2019-09-27T05:58:40.2273315Z | 2019-09-27T05:58:40.2273391Z note: lint level defined here 2019-09-27T05:58:40.2273777Z --> /checkout/src/test/ui/lint/lint-exceeding-bitshifts2.rs:1:30 2019-09-27T05:58:40.2274103Z | 2019-09-27T05:58:40.2274103Z | 2019-09-27T05:58:40.2274214Z LL | #![deny(exceeding_bitshifts, const_err)] 2019-09-27T05:58:40.2274382Z 2019-09-27T05:58:40.2274382Z 2019-09-27T05:58:40.2274458Z error: attempt to shift left with overflow 2019-09-27T05:58:40.2275067Z | 2019-09-27T05:58:40.2275067Z | 2019-09-27T05:58:40.2275178Z LL | let n = 1_isize << BITS; //~ ERROR: attempt to shift left with overflow 2019-09-27T05:58:40.2275354Z 2019-09-27T05:58:40.2275354Z 2019-09-27T05:58:40.2275429Z error: attempt to shift left with overflow 2019-09-27T05:58:40.2275922Z | 2019-09-27T05:58:40.2275922Z | 2019-09-27T05:58:40.2276034Z LL | let n = 1_usize << BITS; //~ ERROR: attempt to shift left with overflow 2019-09-27T05:58:40.2276223Z 2019-09-27T05:58:40.2276298Z error: aborting due to 3 previous errors 2019-09-27T05:58:40.2276379Z 2019-09-27T05:58:40.2276424Z --- 2019-09-27T05:58:40.2286374Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:537:22 2019-09-27T05:58:40.2286558Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace. 2019-09-27T05:58:40.2301037Z 2019-09-27T05:58:40.2301330Z 2019-09-27T05:58:40.2303942Z command did not execute successfully: "/checkout/obj/build/i686-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/i686-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/i686-unknown-linux-gnu/test/ui" "--stage-id" "stage2-i686-unknown-linux-gnu" "--mode" "ui" "--target" "i686-unknown-linux-gnu" "--host" "i686-unknown-linux-gnu" "--llvm-filecheck" "/checkout/obj/build/i686-unknown-linux-gnu/llvm/build/bin/FileCheck" "--host-rustcflags" "-Crpath -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -Cdebuginfo=0 -Zunstable-options -Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--llvm-version" "9.0.0-rust-1.40.0-dev\n" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--llvm-cxxflags" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always" 2019-09-27T05:58:40.2305039Z 2019-09-27T05:58:40.2305234Z 2019-09-27T05:58:40.2314214Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test 2019-09-27T05:58:40.2314696Z Build completed unsuccessfully in 1:31:00 2019-09-27T05:58:40.2314696Z Build completed unsuccessfully in 1:31:00 2019-09-27T05:58:40.2373411Z == clock drift check == 2019-09-27T05:58:40.2391495Z local time: Fri Sep 27 05:58:40 UTC 2019 2019-09-27T05:58:40.5053450Z network time: Fri, 27 Sep 2019 05:58:40 GMT 2019-09-27T05:58:40.5053602Z == end clock drift check == 2019-09-27T05:58:41.4878482Z ##[error]Bash exited with code '1'. 2019-09-27T05:58:41.4929867Z ##[section]Starting: Upload CPU usage statistics 2019-09-27T05:58:41.4937606Z ============================================================================== 2019-09-27T05:58:41.4937733Z Task : Bash 2019-09-27T05:58:41.4937818Z Description : Run a Bash script on macOS, Linux, or Windows 

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Sep 27, 2019
@Centril Centril closed this Sep 27, 2019
@Centril Centril deleted the rollup-mo16xm6 branch September 27, 2019 06:03
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.