Improve error span for async type inference error #62383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixes rust-lang#62382 Previously, we would point at the spawn of the 'await' expression, instead of the actual expression with an unknown type.
| r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive added the S-waiting-on-review 
| @bors r+ rollup |
| 📌 Commit 779308a has been approved by |
bors added S-waiting-on-bors Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019
…arkor Improve error span for async type inference error Fixes rust-lang#62382 Previously, we would point at the spawn of the 'await' expression, instead of the actual expression with an unknown type.
Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019
…arkor Improve error span for async type inference error Fixes rust-lang#62382 Previously, we would point at the spawn of the 'await' expression, instead of the actual expression with an unknown type.
bors added a commit that referenced this pull request Jul 5, 2019
Rollup of 10 pull requests Successful merges: - #62123 ( Remove needless lifetimes (std)) - #62150 (Implement mem::{zeroed,uninitialized} in terms of MaybeUninit.) - #62169 (Derive which queries to save using the proc macro) - #62238 (Fix code block information icon position) - #62292 (Move `async || ...` closures into `#![feature(async_closure)]`) - #62323 (Clarify unaligned fields in ptr::{read,write}_unaligned) - #62324 (Reduce reliance on `await!(...)` macro) - #62371 (Add tracking issue for Box::into_pin) - #62383 (Improve error span for async type inference error) - #62388 (Break out of the correct number of scopes in loops) Failed merges: r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #62382
Previously, we would point at the spawn of the 'await' expression,
instead of the actual expression with an unknown type.