Make the Weak::{into,as}_raw methods #61862
Merged
+30 −30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Because Weak doesn't Deref, so there's no reason for them to be only associated methods.
Contributor
| (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive added the S-waiting-on-review 
Contributor Author
| Hello. Could someone have a look at this? It's sitting here for some time… I believe the build failure on azure was some kind of azure breakage during the experiment (the build didn't even start); travis were successful. |
Contributor
| cc @sfackler |
Member
| @bors r+ |
Collaborator
| 📌 Commit 49fbd76 has been approved by |
bors added S-waiting-on-bors Centril added a commit to Centril/rust that referenced this pull request Jul 6, 2019
…ckler Make the Weak::{into,as}_raw methods Because Weak doesn't Deref, so there's no reason for them to be only associated methods. As kindly pointed out here rust-lang#60766 (comment) by @chpio. bors added a commit that referenced this pull request Jul 6, 2019
Rollup of 6 pull requests Successful merges: - #60081 (Refactor unicode.py script) - #61862 (Make the Weak::{into,as}_raw methods) - #62243 (Improve documentation for built-in macros) - #62422 (Remove some uses of mem::uninitialized) - #62432 (Update rustfmt to 1.3.2) - #62436 (normalize use of backticks/lowercase in compiler messages for librustc_mir) Failed merges: r? @ghost
Centril added a commit to Centril/rust that referenced this pull request Jul 6, 2019
…ckler Make the Weak::{into,as}_raw methods Because Weak doesn't Deref, so there's no reason for them to be only associated methods. As kindly pointed out here rust-lang#60766 (comment) by @chpio. bors added a commit that referenced this pull request Jul 6, 2019
Rollup of 5 pull requests Successful merges: - #60081 (Refactor unicode.py script) - #61862 (Make the Weak::{into,as}_raw methods) - #62243 (Improve documentation for built-in macros) - #62422 (Remove some uses of mem::uninitialized) - #62436 (normalize use of backticks/lowercase in compiler messages for librustc_mir) Failed merges: r? @ghost
Collaborator
Contributor Author
| Thank you :-) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Because Weak doesn't Deref, so there's no reason for them to be only
associated methods.
As kindly pointed out here #60766 (comment) by @chpio.