rustc: Remove dylib crate type from most rustc crates #59800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rust-highfive added the S-waiting-on-review 
| r=me on this, sorry I was never able to get to the bottom of the issues! |
This comment has been minimized.
This comment has been minimized.
| Thanks for looking into this, @Zoxc! |
This comment has been minimized.
This comment has been minimized.
petrochenkov reviewed Apr 9, 2019
Zoxc force-pushed the less-dylibs branch 2 times, most recently from 1e51c9b to 581705d Compare This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Zoxc force-pushed the less-dylibs branch 2 times, most recently from e38953e to 535f9e7 Compare | Blocked on #59752 landing in beta. |
Zoxc added the S-blocked Zoxc changed the title dylib crate type from most rustc cratesdylib crate type from most rustc crates This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Dylan-DPC-zz removed the S-waiting-on-review This comment has been minimized.
This comment has been minimized.
| This is now unblocked. |
Zoxc added S-waiting-on-review 
bjorn3 reviewed Jun 15, 2019
Now that procedural macros no longer link transitively to libsyntax, this shouldn't be needed any more! This commit is an experiment in removing all dynamic libraries from rustc except for librustc_driver itself. Let's see how far we can get with that!
| @bors r=alexcrichton |
| 📌 Commit 7198687 has been approved by |
bors added S-waiting-on-bors bors added a commit that referenced this pull request Jul 7, 2019
rustc: Remove `dylib` crate type from most rustc crates Revival of #56987 cc @alexcrichton r? @michaelwoerister
| ☀️ Test successful - checks-azure, checks-travis, status-appveyor |
rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 7, 2019
Tested on commit rust-lang/rust@dd2e804. Direct link to PR: <rust-lang/rust#59800> 💔 rls on linux: test-pass → test-fail (cc @Xanewok, @rust-lang/infra).
SimonSapin added a commit to SimonSapin/rust that referenced this pull request Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Revival of #56987
cc @alexcrichton
r? @michaelwoerister