Updated RELEASES.md for 1.34.0 #59599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rust-highfive added the S-waiting-on-review 
Centril reviewed Apr 1, 2019
There was a problem hiding this comment.
Note to @steveklabnik & et. al -- I think these should be our headline items in order of importance (0. being most important) in the blog post.
tesuji reviewed Apr 1, 2019
tormol reviewed Apr 1, 2019
kennytm added the beta-nominated 
jonas-schievink added the T-release 
pietroalbini added the beta-accepted 
| Out-of-topic: Speaking of targets, i think https://forge.rust-lang.org/platform-support.html has been out of date for quite a while... targets such as uefi have never been labeled a tier, and added to the table :( |
| Can we get this finished up for the release? |
Co-Authored-By: XAMPPRocky <4464295+XAMPPRocky@users.noreply.github.com>
| @bors r+ Not giving priority as it landing on beta is more important -- master can wait. |
| 📌 Commit 4ba3034 has been approved by |
bors added S-waiting-on-bors Centril added a commit to Centril/rust that referenced this pull request Apr 5, 2019
Updated RELEASES.md for 1.34.0 [Rendered](https://github.com/XAMPPRocky/rust/blob/master/RELEASES.md) This also corrects an omission in the previous 1.33.0 release. r? @Mark-Simulacrum cc @rust-lang/release
pietroalbini removed the beta-nominated Centril added a commit to Centril/rust that referenced this pull request Apr 5, 2019
Updated RELEASES.md for 1.34.0 [Rendered](https://github.com/XAMPPRocky/rust/blob/master/RELEASES.md) This also corrects an omission in the previous 1.33.0 release. r? @Mark-Simulacrum cc @rust-lang/release
bors added a commit that referenced this pull request Apr 5, 2019
Rollup of 6 pull requests Successful merges: - #58894 (Fix invalid bounds string generation in rustdoc) - #59599 (Updated RELEASES.md for 1.34.0) - #59624 (SGX target: Use linker option to avoid code CGU assignment kludge) - #59696 (Remove invalid assertion back::link::from add_upstream_rust_crates().) - #59707 (Add missing tryfrom example) - #59727 (wasi: Use shared API for preopened fds) Failed merges: r? @ghost
bors added a commit that referenced this pull request Apr 7, 2019
[beta] Rollup backports Cherry-picked: * #58021: Fix fallout from #57667 * #59599: Updated RELEASES.md for 1.34.0 * #59587: Remove #[doc(hidden)] from Error::type_id * #58994: Hide deprecation warnings inside derive expansions * #58015: Expand docs for `TryFrom` and `TryInto`. * #59770: ci: pin android emulator to 28.0.23 * #59704: ci: Update FreeBSD tarball downloads * #59257: Update CI configuration for building Redox libraries * #59724: Function arguments should never get promoted r? @ghost
bors added a commit that referenced this pull request Apr 8, 2019
[beta] Rollup backports Cherry-picked: * #58021: Fix fallout from #57667 * #59599: Updated RELEASES.md for 1.34.0 * #59587: Remove #[doc(hidden)] from Error::type_id * #58994: Hide deprecation warnings inside derive expansions * #58015: Expand docs for `TryFrom` and `TryInto`. * #59770: ci: pin android emulator to 28.0.23 * #59704: ci: Update FreeBSD tarball downloads * #59257: Update CI configuration for building Redox libraries * #59724: Function arguments should never get promoted * #59499: Fix broken download link in the armhf-gnu image * #58330: Add rustdoc JS non-std tests * #58848: Prevent cache issues on version updates r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Rendered
This also corrects an omission in the previous 1.33.0 release.
r? @Mark-Simulacrum
cc @rust-lang/release