Reduces Code Repetitions like !n >> amt #59101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive added the S-waiting-on-review 
kenta7777 changed the title !n >> amt 
| r? @oli-obk |
oli-obk reviewed Mar 11, 2019
| // FIXME(49937): refactor these bit manipulations into interpret. | ||
| let size = Integer::from_attr(&tcx, SignedInt(ity)).size(); | ||
| let max = !0u128 >> (128 - size.bits()); | ||
| let max = mask(size); |
There was a problem hiding this comment.
this could be truncate(u128::max_value(), size)
There was a problem hiding this comment.
Thank you for your review. Then, should I replace mask with truncate and remove the definition of mask?
There was a problem hiding this comment.
yes, I think that's for the best, unless you see a lot of other sites in the compiler where using mask would make sense.
| @bors r+ Thanks! |
| 📌 Commit 18b40c6 has been approved by |
bors added S-waiting-on-bors | @bors rollup |
kennytm added a commit to kennytm/rust that referenced this pull request Mar 11, 2019
…=oli-obk Reduces Code Repetitions like `!n >> amt` Fixes rust-lang#49937 . This PR contains defining a function which operates bit inversion and reducing bit operation like `!0u128 >> (128 - size.bits())`.
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Mar 12, 2019
…=oli-obk Reduces Code Repetitions like `!n >> amt` Fixes rust-lang#49937 . This PR contains defining a function which operates bit inversion and reducing bit operation like `!0u128 >> (128 - size.bits())`.
Centril added a commit to Centril/rust that referenced this pull request Mar 13, 2019
…=oli-obk Reduces Code Repetitions like `!n >> amt` Fixes rust-lang#49937 . This PR contains defining a function which operates bit inversion and reducing bit operation like `!0u128 >> (128 - size.bits())`.
bors added a commit that referenced this pull request Mar 13, 2019
Rollup of 16 pull requests Successful merges: - #58829 (librustc_interface: Update scoped-tls to 1.0) - #58876 (Parse lifetimes that start with a number and give specific error) - #58908 (Update rand version) - #58998 (Fix documentation of from_ne_bytes and from_le_bytes) - #59056 (Use lifetime contravariance to elide more lifetimes in core+alloc+std) - #59057 (Standardize `Range*` documentation) - #59080 (Fix incorrect links in librustc_codegen_llvm documentation) - #59083 (Fix #54822 and associated faulty tests) - #59093 (Remove precompute_in_scope_traits_hashes) - #59101 (Reduces Code Repetitions like `!n >> amt`) - #59121 (impl FromIterator for Result: Use assert_eq! instead of assert!) - #59124 (Replace assert with assert_eq) - #59129 (Visit impl Trait for dead_code lint) - #59130 (Note that NonNull does not launder shared references for mutation) - #59132 (ignore higher-ranked object bound conditions created by WF) - #59138 (Simplify Iterator::{min, max}) Failed merges: r? @ghost
| Thanks! |
varkor reviewed Mar 13, 2019
| (Some(('\u{0000}' as u128, '\u{10FFFF}' as u128, Size::from_bits(32))), 0) | ||
| } | ||
| ty::Int(ity) => { | ||
| // FIXME(49937): refactor these bit manipulations into interpret. |
There was a problem hiding this comment.
These FIXMEs look resolved now.
There was a problem hiding this comment.
Thank you for reporting. I forgot to remove this comment out.
There was a problem hiding this comment.
I think let bias = 1u128 << (size.bits() - 1); is not resolved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #49937 .
This PR contains defining a function which operates bit inversion and reducing bit operation like
!0u128 >> (128 - size.bits()).