libpanic_unwind => 2018 #58110
Merged
libpanic_unwind => 2018 #58110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rust-highfive added the S-waiting-on-review 78 tasks
This comment has been minimized.
This comment has been minimized.
| r=me rollup with travis passing |
Merged
Centril force-pushed the libpanic_unwind-2018 branch from 19786bc to 6127151 Compare This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @oli-obk Here's a full dump with backtrace: https://gist.github.com/Centril/70b383fd22cb4e233a3cbcd6f750f600 ; it doesn't exactly happen at the same point, but hopefully it has enough detail... |
Centril force-pushed the libpanic_unwind-2018 branch from 6127151 to c34e14e Compare | @oli-obk Resolved the ICEs locally, but please double check that it was done in a way that doesn't have bad implications elsewhere. |
oli-obk reviewed Feb 13, 2019
oli-obk reviewed Feb 13, 2019
Centril force-pushed the libpanic_unwind-2018 branch from c34e14e to 3657eaa Compare | @bors r+ |
| 📌 Commit 3657eaa has been approved by |
bors added S-waiting-on-bors Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019
…-obk libpanic_unwind => 2018 Transitions `libpanic_unwind` to Rust 2018; cc rust-lang#58099 r? @oli-obk
| Failed in rollup (#58428 (comment)), @bors r- |
bors added S-waiting-on-author 
Centril force-pushed the libpanic_unwind-2018 branch from 3657eaa to bb08499 Compare | @bors r=oli-obk |
| 📌 Commit bb08499 has been approved by |
bors added S-waiting-on-bors Centril added a commit to Centril/rust that referenced this pull request Feb 13, 2019
…-obk libpanic_unwind => 2018 Transitions `libpanic_unwind` to Rust 2018; cc rust-lang#58099 r? @oli-obk
bors added a commit that referenced this pull request Feb 13, 2019
Rollup of 10 pull requests Successful merges: - #58110 (libpanic_unwind => 2018) - #58167 (HirId-ify hir::BodyId) - #58202 (Ignore future deprecations in #[deprecated]) - #58272 (Cut down on number formating code size) - #58276 (Improve the error messages for missing stability attributes) - #58354 (Fix ICE and invalid filenames in MIR printing code) - #58381 (Only suggest imports if not imported.) - #58386 (Fix #54242) - #58400 (Fix rustc_driver swallowing errors when compilation is stopped) - #58420 (target/uefi: clarify documentation) Failed merges: r? @ghost
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Transitions
libpanic_unwindto Rust 2018; cc #58099r? @oli-obk