Skip to content

Conversation

@pthariensflame
Copy link
Contributor

The into_to_from_bytes feature was stabilized for i128 and u128 just like for the other integer types, but they seem to have been missed.

The `into_to_from_bytes` feature was stabilized for `i128` and `u128` just like for the other integer types, but they seem to have been missed.
@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 11, 2019
@alexcrichton
Copy link
Member

I think these may be missing hyperlinks below as well?

@pthariensflame
Copy link
Contributor Author

@alexcrichton Fixed! Sorry about that!

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Collaborator

bors commented Jan 12, 2019

📌 Commit fdd2f0d has been approved by alexcrichton

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 12, 2019
@alexcrichton
Copy link
Member

@bors: rollup

Centril added a commit to Centril/rust that referenced this pull request Jan 12, 2019
Correct RELEASES.md for 1.32.0 The `into_to_from_bytes` feature was stabilized for `i128` and `u128` just like for the other integer types, but they seem to have been missed.
bors added a commit that referenced this pull request Jan 12, 2019
Rollup of 26 pull requests Successful merges: - #56425 (Redo the docs for Vec::set_len) - #56906 (Issue #56905) - #57042 (Don't call `FieldPlacement::count` when count is too large) - #57175 (Stabilize `let` bindings and destructuring in constants and const fn) - #57192 (Change std::error::Error trait documentation to talk about `source` instead of `cause`) - #57296 (Fixed the link to the ? operator) - #57368 (Use CMAKE_{C,CXX}_COMPILER_LAUNCHER for ccache) - #57400 (Rustdoc: update Source Serif Pro and replace Heuristica italic) - #57417 (rustdoc: use text-based doctest parsing if a macro is wrapping main) - #57433 (Add link destination for `read-ownership`) - #57434 (Remove `CrateNum::Invalid`.) - #57441 (Supporting backtrace for x86_64-fortanix-unknown-sgx.) - #57450 (actually take a slice in this example) - #57459 (Reference tracking issue for inherent associated types in diagnostic) - #57463 (docs: Fix some 'second-edition' links) - #57466 (Remove outdated comment) - #57493 (use structured suggestion when casting a reference) - #57498 (make note of one more normalization that Paths do) - #57499 (note that FromStr does not work for borrowed types) - #57505 (Remove submodule step from README) - #57510 (Add a profiles section to the manifest) - #57511 (Fix undefined behavior) - #57519 (Correct RELEASES.md for 1.32.0) - #57522 (don't unwrap unexpected tokens in `format!`) - #57530 (Fixing a typographical error.) - #57535 (Stabilise irrefutable if-let and while-let patterns) Failed merges: r? @ghost
@pietroalbini pietroalbini added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Jan 12, 2019
@pietroalbini
Copy link
Member

Accepted for beta backport. @Mark-Simulacrum we need to remember to cherry-pick this into the promotion PR.

@bors bors merged commit fdd2f0d into rust-lang:master Jan 12, 2019
@pthariensflame pthariensflame deleted the patch-2 branch January 12, 2019 15:28
@pietroalbini pietroalbini removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Jan 14, 2019
@pietroalbini
Copy link
Member

Cherry-picked this inside the release PR.

bors added a commit that referenced this pull request Jan 16, 2019
Rust 1.32.0 stable release Also cherry-picked the following beta-accepted PRs: * #57519: Correct RELEASES.md for 1.32.0 r? @Mark-Simulacrum cc @rust-lang/release
bors added a commit that referenced this pull request Jan 16, 2019
Rust 1.32.0 stable release Also cherry-picked the following beta-accepted PRs: * #57519: Correct RELEASES.md for 1.32.0 r? @Mark-Simulacrum cc @rust-lang/release
bors added a commit that referenced this pull request Jan 16, 2019
Rust 1.32.0 stable release Also cherry-picked the following beta-accepted PRs: * #57519: Correct RELEASES.md for 1.32.0 r? @Mark-Simulacrum cc @rust-lang/release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-release Relevant to the release subteam, which will review and decide on the PR/issue.

5 participants