Fix irrefutable matches on integer ranges #56695
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive added the S-waiting-on-review 
oli-obk requested changes Dec 11, 2018
varkor force-pushed the let-exhaustive-range branch from 91f1422 to 510a9ff Compare 
| @bors r+ |
| 📌 Commit 510a9ff has been approved by |
bors added S-waiting-on-bors kennytm added a commit to kennytm/rust that referenced this pull request Dec 13, 2018
…bank Fix irrefutable matches on integer ranges Fixes rust-lang#56659.
kennytm added a commit to kennytm/rust that referenced this pull request Dec 14, 2018
…bank Fix irrefutable matches on integer ranges Fixes rust-lang#56659.
kennytm added a commit to kennytm/rust that referenced this pull request Dec 14, 2018
…bank Fix irrefutable matches on integer ranges Fixes rust-lang#56659.
This was referenced Dec 14, 2018
bors added a commit that referenced this pull request Dec 14, 2018
Rollup of 14 pull requests (first batch) Successful merges: - #56562 (Update libc version required by rustc) - #56609 (Unconditionally emit the target-cpu LLVM attribute.) - #56637 (rustdoc: Fix local reexports of proc macros) - #56658 (Add non-panicking `maybe_new_parser_from_file` variant) - #56695 (Fix irrefutable matches on integer ranges) - #56699 (Use a `newtype_index!` within `Symbol`.) - #56702 ([self-profiler] Add column for percent of total time) - #56708 (Remove some unnecessary feature gates) - #56709 (Remove unneeded extra chars to reduce search-index size) - #56744 (specialize: remove Boxes used by Children::insert) - #56748 (Update panic message to be clearer about env-vars) - #56749 (x86: Add the `adx` target feature to whitelist) - #56756 (Disable btree pretty-printers on older gdbs) - #56789 (rustc: Add an unstable `simd_select_bitmask` intrinsic) r? @ghost
| @varkor thanks for fixing this! I didn't really expect it, since that usage seems very unrealistic. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #56659.