Skip to content

Conversation

@GuillaumeGomez
Copy link
Member

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 8, 2018
@QuietMisdreavus
Copy link
Contributor

Can you add a screenshot for this? I think this is generally useful, but i want to double-check how it's supposed to render first.

@GuillaumeGomez
Copy link
Member Author

screen shot 2018-10-08 at 22 50 24

@QuietMisdreavus
Copy link
Contributor

Thanks! Looks good!

@bors r+

@bors
Copy link
Collaborator

bors commented Oct 24, 2018

📌 Commit e961d39 has been approved by QuietMisdreavus

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 24, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Oct 25, 2018
…tMisdreavus Add line numbers option to rustdoc Fixes rust-lang#22878.
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Oct 25, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Oct 26, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Oct 26, 2018
bors added a commit that referenced this pull request Oct 26, 2018
Rollup of 21 pull requests Successful merges: - #54816 (Don't try to promote already promoted out temporaries) - #54824 (Cleanup rustdoc tests with `@!has` and `@!matches`) - #54921 (Add line numbers option to rustdoc) - #55167 (Add a "cheap" mode for `compute_missing_ctors`.) - #55258 (Fix Rustdoc ICE when checking blanket impls) - #55264 (Compile the libstd we distribute with -Ccodegen-unit=1) - #55271 (Unimplement ExactSizeIterator for MIR traversing iterators) - #55292 (Macro diagnostics tweaks) - #55298 (Point at macro definition when no rules expect token) - #55301 (List allowed tokens after macro fragments) - #55302 (Extend the impl_stable_hash_for! macro for miri.) - #55325 (Fix link to macros chapter) - #55343 (rustbuild: fix remap-debuginfo when building a release) - #55346 (Shrink `Statement`.) - #55358 (Remove redundant clone (2)) - #55370 (Update mailmap for estebank) - #55375 (Typo fixes in configure_cmake comments) - #55378 (rustbuild: use configured linker to build boostrap) - #55379 (validity: assert that unions are non-empty) - #55383 (Use `SmallVec` for the queue in `coerce_unsized`.) - #55391 (bootstrap: clean up a few clippy findings)
@bors bors merged commit e961d39 into rust-lang:master Oct 26, 2018
@GuillaumeGomez GuillaumeGomez deleted the line-numbers branch October 27, 2018 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

4 participants