Skip to content

Conversation

@emilio
Copy link
Contributor

@emilio emilio commented Aug 27, 2018

No description provided.

@rust-highfive
Copy link
Contributor

r? @estebank

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2018
@emilio
Copy link
Contributor Author

emilio commented Aug 27, 2018

r? @nrc

@rust-highfive rust-highfive assigned nrc and unassigned estebank Aug 27, 2018
@nrc
Copy link
Member

nrc commented Aug 27, 2018

@bors: r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 27, 2018

📌 Commit 4570ace has been approved by nrc

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 27, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Aug 28, 2018
save-analysis: Differentiate foreign functions and statics.
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Aug 28, 2018
save-analysis: Differentiate foreign functions and statics.
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 29, 2018
save-analysis: Differentiate foreign functions and statics.
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 29, 2018
save-analysis: Differentiate foreign functions and statics.
pietroalbini added a commit to pietroalbini/rust that referenced this pull request Aug 30, 2018
save-analysis: Differentiate foreign functions and statics.
bors added a commit that referenced this pull request Aug 31, 2018
Rollup of 20 pull requests Successful merges: - #51760 (Add another PartialEq example) - #53113 (Add example for Cow) - #53129 (remove `let x = baz` which was obscuring the real error) - #53389 (document effect of join on memory ordering) - #53472 (Use FxHash{Map,Set} instead of the default Hash{Map,Set} everywhere in rustc.) - #53476 (Add partialeq implementation for TryFromIntError type) - #53513 (Force-inline `shallow_resolve` at its hottest call site.) - #53655 (set applicability) - #53702 (Fix stabilisation version for macro_vis_matcher.) - #53727 (Do not suggest dereferencing in macro) - #53732 (save-analysis: Differentiate foreign functions and statics.) - #53740 (add llvm-readobj to llvm-tools-preview) - #53743 (fix a typo: taget_env -> target_env) - #53747 (Rustdoc fixes) - #53753 (expand keep-stage --help text) - #53756 (Fix typo in comment) - #53768 (move file-extension based .gitignore down to src/) - #53785 (Fix a comment in src/libcore/slice/mod.rs) - #53786 (Replace usages of 'bad_style' with 'nonstandard_style'.) - #53806 (Fix UI issues on Implementations on Foreign types) Failed merges: r? @ghost
@bors bors merged commit 4570ace into rust-lang:master Aug 31, 2018
@emilio emilio deleted the foreign-fn branch August 31, 2018 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.

5 participants