- Notifications
You must be signed in to change notification settings - Fork 14k
Implements RFC 1937: ? in main #46479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
25 commits Select commit Hold shift + click to select a range
d7918fb Implements RFC 1937: `?` in `main`
bkchr b452c43 avoid ICE when fields are not laid out in order
nikomatsakis 19adeaa convert print-type-sizes to use `start` instead of `main`
nikomatsakis 011c9ea Fixes compile bug caused by upstream changes
bkchr 99a108c Fixes compilation errors and adds proposed improvements
bkchr f842f75 Fixes tests
bkchr 8232734 Fall back to main -> () when termination trait language item is not e…
bkchr 267800a New generated main returns void
bkchr 8f539b0 Fixes codegen-units tests
bkchr c7a57d2 Adds termination_trait feature gate
bkchr a8a9a05 Convert codegen-unit tests to use `start` instead of `main`
bkchr 83cb299 Just compare the symbol names and types, not the addresses
bkchr 88bf2b4 Removes some obscure transmute call in `lang_start`
bkchr 347165f The test functions are now in the same compile unit
bkchr faff382 Don't emit the termination lang item in tests
bkchr 072f3eb Use move for optimization purposes
bkchr 7efeeba Use `start` for the `sepcomp-inlining` test
bkchr f972f52 Revert "Just compare the symbol names and types, not the addresses"
bkchr dbbba55 Rework the exit failure and success declaration for wasm32
bkchr c2f22f0 Adds whitespace
bkchr 7dfec34 Split `lang_start` in two functions to reduce generated code
bkchr 81e375d Change name of `lang_start_real` to `lang_start_internal`
bkchr 2cdd1c4 rustc: Switch `start_fn` to hidden visibility
alexcrichton 5a4298b Don't use `process::exit` as it is an `unreachable` on wasm32
bkchr 09f94be Revert "New generated main returns void"
bkchr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Use
start for the sepcomp-inlining test - Loading branch information
commit 7efeeba13a2ca862f8d0f6e1f0f6fd936478b78f
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this might break the point of the test. Could you use
#[start]here?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I compared the output of the test between my version and a version compiled with rust nightly. I think the unwinding stuff by the new
lang_startmoves a lot of stuff in the codegen untis around. But if you have a better idea, I'm open :)