rustbuild: update the rust-src filter for compiler-rt #44203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We wanted `src/compiler-rt/test` filtered from the `rust-src` package, but that path is now `src/libcompiler_builtins/compiler-rt/test`. This saves over half of the installed rust-src size. (50MB -> 22MB)
Contributor
| r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
Member
| @bors r+ |
Collaborator
| 📌 Commit 35f8a20 has been approved by |
Member
| @bors rollup |
aidanhs added the S-waiting-on-bors GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Aug 31, 2017
…mulacrum rustbuild: update the rust-src filter for compiler-rt We wanted `src/compiler-rt/test` filtered from the `rust-src` package, but that path is now `src/libcompiler_builtins/compiler-rt/test`. This saves over half of the installed rust-src size. (50MB -> 22MB)
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Sep 1, 2017
…mulacrum rustbuild: update the rust-src filter for compiler-rt We wanted `src/compiler-rt/test` filtered from the `rust-src` package, but that path is now `src/libcompiler_builtins/compiler-rt/test`. This saves over half of the installed rust-src size. (50MB -> 22MB)
Collaborator
| ☔ The latest upstream changes (presumably #44233) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We wanted
src/compiler-rt/testfiltered from therust-srcpackage,but that path is now
src/libcompiler_builtins/compiler-rt/test. Thissaves over half of the installed rust-src size. (50MB -> 22MB)