lower move_val_init during MIR construction #41361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Because of its "magic" order-of-evaluation semantics, `move_val_init` must be lowered during MIR construction in order to work.
| I thought @pnkfelix was happy with moving the |
| i said this on IRC, but repeating here for the record: I'm not attached to the desugaring approach. It was more attractive before we had MIR. but if this PR improves the current state of |
| @bors r+ |
| 📌 Commit ed3810b has been approved by |
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 18, 2017
lower `move_val_init` during MIR construction Because of its "magic" order-of-evaluation semantics, `move_val_init` must be lowered during MIR construction in order to work without needing a temporary. r? @eddyb
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 18, 2017
lower `move_val_init` during MIR construction Because of its "magic" order-of-evaluation semantics, `move_val_init` must be lowered during MIR construction in order to work without needing a temporary. r? @eddyb
This was referenced Apr 18, 2017
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 18, 2017
lower `move_val_init` during MIR construction Because of its "magic" order-of-evaluation semantics, `move_val_init` must be lowered during MIR construction in order to work without needing a temporary. r? @eddyb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Because of its "magic" order-of-evaluation semantics,
move_val_initmust be lowered during MIR construction in order to work without needing a temporary.r? @eddyb