parser: show a helpful note on unexpected inner comment #33333
Conversation
| (rust_highfive has picked a reviewer for you, use r? to override) |
src/test/parse-fail/issue-30318.rs Outdated
There was a problem hiding this comment.
I guess :) will fix with the new message.
There was a problem hiding this comment.
(btw, ping me when you need re-review, I'm not actively watching the PRs)
| @Wafflespeanut had attempted a more comprehensive diagnostics overhaul of the parser when it comes to unexpected comments-that-aren't, but it didn't work out so well IIRC. |
| r? @Manishearth |
src/libsyntax/parse/attr.rs Outdated
There was a problem hiding this comment.
s/must be placed before any items/can only appear before items/
| @bors delegate+ with minor nit |
| ✌️ @birkenfeld can now approve this pull request |
| @bors r=Manishearth |
| 📌 Commit b446c99 has been approved by |
| ⌛ Testing commit b446c99 with merge 9cce34c... |
| 💔 Test failed - auto-linux-64-cross-armhf |
src/libsyntax/parse/attr.rs Outdated
| @bors r=Manishearth 72560e1 |
| @bors r+ |
| 💡 This pull request was already approved, no need to approve it again.
|
| 📌 Commit 72560e1 has been approved by |
| ⌛ Testing commit 72560e1 with merge 0d61bb3... |
parser: show a helpful note on unexpected inner comment Fixes: #30318.
5 participants
Fixes: #30318.