Add missing #[inline] to methods related to char and fix related problem in String::push #26154
Conversation
| Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @bors r+ |
| 📌 Commit c5d0e2a has been approved by |
…character's UTF-8 representation is bigger than 1 byte
pmarcelll changed the title | @SimonSapin, since you are the original author of the modified code, could you please look at the second commit to see if there's anything wrong with it? 😃 |
| @bors r+ |
| 📌 Commit e87c62f has been approved by |
| Thanks! |
| @pmarcelll I am? Anyway, looks good to me. |
| 💔 Test failed - auto-mac-64-nopt-t |
| @bors: retry On Wed, Jun 10, 2015 at 7:08 AM, bors notifications@github.com wrote:
|
7 participants
Various methods in both libcore/char.rs and librustc_unicode/char.rs were previously marked with #[inline], now every method is marked in char's impl blocks.
Partially fixes #26124.
EDIT: I'm not familiar with pull reqests (yet), apparently Github added my second commit to thit PR...
Fixes #26124