configure: Don't disable optimizations when enabling debug #24408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Optimization is now on by default. Closes rust-lang#24405
| r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
| r? @pnkfelix |
| @richo my goal was to preserve the spirit of the original change, under which (However. perhaps this is misguided, and we should simply just do what you suggest here.) |
| Ah. I pondered that for a while, and wound up concluding that optimizations are now the default state. That seems reasonable to me though, will update the patch. |
| @richo well, TBH now I am torn too. I'm going to go ask for opinions in |
This allows you to distinguish between an option that defaulted, and an option selected by the user
| @bors r+ |
| 📌 Commit fd69ac1 has been approved by |
| @bors p=5 |
bors added a commit that referenced this pull request Apr 14, 2015
Optimization is now on by default. Closes #24405
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Optimization is now on by default. Closes #24405