Skip to content

Conversation

@pnkfelix
Copy link
Contributor

@pnkfelix pnkfelix commented Feb 5, 2015

Extend region-inference graphviz rendering with enclosing relationship as well as the constraint edges.

@rust-highfive
Copy link
Contributor

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@pnkfelix
Copy link
Contributor Author

pnkfelix commented Feb 5, 2015

@pnkfelix
Copy link
Contributor Author

pnkfelix commented Feb 5, 2015

(this was spawned off of #21972, but it does not actually block the work there. I found the extra information added by this PR useful at times, but it also introduces noise into the generated graphs. Perhaps I will need to move all of this over to a proper unstable-option where I can specify variants, rather than relying on -Z flags.)

@nikomatsakis
Copy link
Contributor

@bors r+ 576ba8f

I agree though that we'll prob want the ability to customize this more.

@bors
Copy link
Collaborator

bors commented Feb 7, 2015

⌛ Testing commit 576ba8f with merge 4bb2d9c...

@bors
Copy link
Collaborator

bors commented Feb 7, 2015

💔 Test failed - auto-mac-64-opt

@pnkfelix
Copy link
Contributor Author

pnkfelix commented Feb 7, 2015

@bors r=nikomatsakis 7610feb

bors added a commit that referenced this pull request Feb 7, 2015
…tsakis Extend region-inference graphviz rendering with enclosing relationship as well as the constraint edges.
@bors
Copy link
Collaborator

bors commented Feb 7, 2015

⌛ Testing commit 7610feb with merge ce5aad2...

@bors bors merged commit 7610feb into rust-lang:master Feb 7, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants