Skip to content

Change DST syntax: type -> Sized? #15521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 8, 2014
Merged

Change DST syntax: type -> Sized? #15521

merged 1 commit into from
Jul 8, 2014

Conversation

@nrc
Copy link
Member

@nrc nrc commented Jul 8, 2014

closes #13367

[breaking-change] Use Sized? to indicate a dynamically sized type parameter or trait (used to be type). E.g.,

trait Tr for Sized? {} fn foo<Sized? X: Share>(x: X) {}
Change DST syntax: type -> Sized?
a0cfda5 
closes rust-lang#13367 [breaking-change] Use `Sized?` to indicate a dynamically sized type parameter or trait (used to be `type`). E.g., ``` trait Tr for Sized? {} fn foo<Sized? X: Share>(x: X) {} ```
@nrc
Copy link
Member Author

nrc commented Jul 8, 2014

r? anyone?
@nrc nrc mentioned this pull request Jul 8, 2014
Closed
23 tasks
bors added a commit that referenced this pull request Jul 8, 2014
@bors
auto merge of #15521 : nick29581/rust/type, r=pcwalton
35e2134 
closes #13367 [breaking-change] Use `Sized?` to indicate a dynamically sized type parameter or trait (used to be `type`). E.g., ``` trait Tr for Sized? {} fn foo<Sized? X: Share>(x: X) {} ```
@lilyball
Copy link
Contributor

lilyball commented Jul 8, 2014

FWIW the [breaking-change] is supposed to go at the end of the message on its own line. I don't know if that actually practically affects any tools, but that's the way it's documented.
@bors bors closed this Jul 8, 2014
@bors bors merged commit a0cfda5 into rust-lang:master Jul 8, 2014
@nrc nrc deleted the type branch July 8, 2014 20:01
@fmease fmease mentioned this pull request Dec 20, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 22, 2023
@matthiaskrgr
Rollup merge of rust-lang#119169 - fmease:pretty-yeet-syntactic-cruft…
15dc9f5 
…, r=compiler-errors Rid the AST & HIR pretty printer of cruft Found while working on rust-lang#119163. For `trait Trait: ?Sized {}` (semantically malformed), we currently output `trait Trait for ? Sized {}` (sic!) / `trait Trait for ? Sized { }` (sic!) if `-Zunpretty=expanded` / `-Zunpretty=hir` is passed. `trait Tr for Sized? {}` (rust-lang#15521) and later also `trait Tr for ?Sized {}` (I guess, rust-lang#20194) is former Rust syntax. Hence I'm removing these outdated branches. ~~This will conflict with rust-lang#119163, therefore marking this PR as blocked.~~ Rebased
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 22, 2023
@rust-timer
Unrolled build for rust-lang#119169
8f6c827 
Rollup merge of rust-lang#119169 - fmease:pretty-yeet-syntactic-cruft, r=compiler-errors Rid the AST & HIR pretty printer of cruft Found while working on rust-lang#119163. For `trait Trait: ?Sized {}` (semantically malformed), we currently output `trait Trait for ? Sized {}` (sic!) / `trait Trait for ? Sized { }` (sic!) if `-Zunpretty=expanded` / `-Zunpretty=hir` is passed. `trait Tr for Sized? {}` (rust-lang#15521) and later also `trait Tr for ?Sized {}` (I guess, rust-lang#20194) is former Rust syntax. Hence I'm removing these outdated branches. ~~This will conflict with rust-lang#119163, therefore marking this PR as blocked.~~ Rebased
flip1995 pushed a commit to flip1995/rust that referenced this pull request Sep 4, 2025
@samueltardieu
clean-up transmute_int_to_non_zero (rust-lang#15521)
65bac18 
changelog: none
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants

@nrc @lilyball @pcwalton @bors