miri: add miri_spin_loop to make hint::spin_loop work consistently #150088
+19 −0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Collaborator
| The Miri subtree was changed cc @rust-lang/miri |
rustbot added S-waiting-on-review 
This comment has been minimized.
This comment has been minimized.
folkertdev force-pushed the riscv-pause-miri branch from 4fbc49f to 7f022df Compare 
RalfJung requested changes Dec 17, 2025
rustbot added S-waiting-on-author Collaborator
| Reminder, once the PR becomes ready for a review, use |
folkertdev force-pushed the riscv-pause-miri branch 2 times, most recently from eef6c46 to c3be846 Compare RalfJung reviewed Dec 17, 2025
folkertdev force-pushed the riscv-pause-miri branch from c3be846 to c7dd19b Compare 
Member
| Thanks, LGTM! r=me when CI is green. |
Collaborator
| ✌️ @folkertdev, you can now approve this pull request! If @RalfJung told you to " |
Contributor Author
| @bors r=RalfJung |
Collaborator
bors added S-waiting-on-bors matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 17, 2025
…fJung miri: add `miri_spin_loop` to make `hint::spin_loop` work consistently fixes rust-lang#150050 Always use the same implementation when running miri (regardless of target, for consistency). This implementation yields the current thread to try find actual bugs. r? RalfJung
This was referenced Dec 17, 2025
bors added a commit that referenced this pull request Dec 17, 2025
Rollup of 4 pull requests Successful merges: - #149919 (Correctly encode doc attribute metadata) - #150051 (mir_build: Rename `TestCase` to `TestableCase`) - #150088 (miri: add `miri_spin_loop` to make `hint::spin_loop` work consistently) - #150096 (Revert #148937) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit that referenced this pull request Dec 17, 2025
Rollup merge of #150088 - folkertdev:riscv-pause-miri, r=RalfJung miri: add `miri_spin_loop` to make `hint::spin_loop` work consistently fixes #150050 Always use the same implementation when running miri (regardless of target, for consistency). This implementation yields the current thread to try find actual bugs. r? RalfJung
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Dec 18, 2025
Rollup of 4 pull requests Successful merges: - rust-lang/rust#149919 (Correctly encode doc attribute metadata) - rust-lang/rust#150051 (mir_build: Rename `TestCase` to `TestableCase`) - rust-lang/rust#150088 (miri: add `miri_spin_loop` to make `hint::spin_loop` work consistently) - rust-lang/rust#150096 (Revert rust-lang/rust#148937) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
fixes #150050
Always use the same implementation when running miri (regardless of target, for consistency). This implementation yields the current thread to try find actual bugs.
r? RalfJung