Do not trust bootstrap about git hash availability #149377
Draft
+60 −27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added A-CI 
This comment was marked as outdated.
This comment was marked as outdated.
This comment has been minimized.
This comment has been minimized.
rust-bors bot added a commit that referenced this pull request Nov 27, 2025
Do not trust bootstrap about git hash availability try-job: aarch64-apple try-job: test-various
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
Since the bootstrap implementation can contain bugs. Instead, we use `RUSTC_TEST_GIT_HASH` env var that is directly set by CI, or by the user locally.
jieyouxu force-pushed the git-hash-availability branch from 299c1fe to 39e27c1 Compare Member Author
| @bors try |
rust-bors bot added a commit that referenced this pull request Nov 27, 2025
Do not trust bootstrap about git hash availability try-job: aarch64-apple try-job: test-various
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
To always run `tests/run-make/version-verbose-commit-hash` in test jobs.
jieyouxu force-pushed the git-hash-availability branch from 39e27c1 to 536faa9 Compare Member Author
| @bors try |
| ⌛ Trying commit 536faa9 with merge 122f76c… To cancel the try build, run the command Workflow: https://github.com/rust-lang/rust/actions/runs/19759629162 |
rust-bors bot added a commit that referenced this pull request Nov 28, 2025
Do not trust bootstrap about git hash availability try-job: aarch64-apple try-job: test-various
Collaborator
| The job Click to see the possible cause of the failure (guessed by this bot) |
Member Author
| @bors try cancel |
| Try build cancelled. Cancelled workflows: |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Since the bootstrap implementation can contain bugs. See #132845 and #132875.
Instead, we use
RUSTC_TEST_GIT_HASHenv var that is directly set by CI, or by the user locally, to control when thetests/run-make/version-verbose-commit-hashgets run. Note that locally, settingRUSTC_TEST_GIT_HASH=1only forces the test to run; the test will only pass if git hash is available, i.e. explicitly opt-in, or using a non-dev channel.Fixes #132875.
r? ghost
try-job: aarch64-apple
try-job: test-various