-
- Notifications
You must be signed in to change notification settings - Fork 14.3k
Ignore #[doc(hidden)] items when computing trimmed paths for printing #148623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| This PR modifies |
| r? @wesleywiser rustbot has assigned @wesleywiser. Use |
This comment has been minimized.
This comment has been minimized.
3d01a43 to 700790b Compare This comment has been minimized.
This comment has been minimized.
700790b to f78921a Compare #[doc(hidden)] items when computing trimmed paths for diagnostics#[doc(hidden)] items when computing trimmed paths for printing | ☔ The latest upstream changes (presumably #148753) made this pull request unmergeable. Please resolve the merge conflicts. |
f78921a to d2ef4a3 Compare This comment has been minimized.
This comment has been minimized.
| ☔ The latest upstream changes (presumably #148789) made this pull request unmergeable. Please resolve the merge conflicts. |
d2ef4a3 to c9a5d13 Compare This comment has been minimized.
This comment has been minimized.
c9a5d13 to 5a21a8f Compare This comment has been minimized.
This comment has been minimized.
| ☔ The latest upstream changes (presumably #147498) made this pull request unmergeable. Please resolve the merge conflicts. |
5a21a8f to 8ec6f89 Compare This comment has been minimized.
This comment has been minimized.
| @rustbot ready |
8ec6f89 to 8f5a7e8 Compare This comment has been minimized.
This comment has been minimized.
8f5a7e8 to 513b6a9 Compare This comment has been minimized.
This comment has been minimized.
| ☔ The latest upstream changes (presumably #149750) made this pull request unmergeable. Please resolve the merge conflicts. |
513b6a9 to 0531a74 Compare This comment has been minimized.
This comment has been minimized.
| @rustbot ready |
0531a74 to a30f76e Compare | This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
The
trimmed_def_pathsquery examines all items in the current crate, and all pub items in immediate-dependency crates (including the standard library), to see which item names are unique and can therefore be printed unambiguously as a bare name without a module path.Currently that query has no special handling for
#[doc(hidden)]items, which has two consequences:This PR therefore makes the
trimmed_def_pathsquery ignore external-crate items that are#[doc(hidden)], along with their descendants.As a result, hidden item names are never considered unique for trimming, and no longer interfere with visible item names being considered unique.