Skip to content

Fix suggestion for returning async closures #148556

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix suggestion for returning async closures #148556

wants to merge 1 commit into from
+236 −0

Conversation

@chenyukang
Copy link
Member

@chenyukang chenyukang commented Nov 6, 2025 •
edited by rustbot
Loading

Fixes #148493
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2025
@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2025

r? @JonathanBrouwer

rustbot has assigned @JonathanBrouwer.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@chenyukang chenyukang mentioned this pull request Nov 6, 2025
Merged
@chenyukang chenyukang force-pushed the yukang-fix-148493-async-closure branch from fe816a3 to 702bf00 Compare November 6, 2025 04:31
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Nov 6, 2025

@bors r+ rollup
@bors
Copy link
Collaborator

bors commented Nov 6, 2025

📌 Commit 702bf00 has been approved by JonathanBrouwer

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 6, 2025
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Nov 6, 2025

I think the automatic merging with #148561 should be fine?
@chenyukang
Copy link
Member Author

chenyukang commented Nov 6, 2025 via email

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 6, 2025
@matthiaskrgr
Rollup merge of rust-lang#148556 - chenyukang:yukang-fix-148493-async…
4e368aa 
…-closure, r=JonathanBrouwer Fix suggestion for returning async closures Fixes rust-lang#148493
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 6, 2025
@matthiaskrgr
Rollup merge of rust-lang#148561 - chenyukang:yukang-fix-148488, r=lqd
806a3d1 
Fix ICE from async closure variance Fixes rust-lang#148488 The fix is also a change from rust-lang#148556
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 6, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 6, 2025
@matthiaskrgr
Rollup merge of rust-lang#148556 - chenyukang:yukang-fix-148493-async…
41908fd 
…-closure, r=JonathanBrouwer Fix suggestion for returning async closures Fixes rust-lang#148493
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 6, 2025
@matthiaskrgr
Rollup merge of rust-lang#148561 - chenyukang:yukang-fix-148488, r=lqd
426cef0 
Fix ICE from async closure variance Fixes rust-lang#148488 The fix is also a change from rust-lang#148556
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 6, 2025
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 6, 2025
@matthiaskrgr
Rollup merge of rust-lang#148561 - chenyukang:yukang-fix-148488, r=lqd
76dae76 
Fix ICE from async closure variance Fixes rust-lang#148488 The fix is also a change from rust-lang#148556
@matthiaskrgr
Copy link
Member

matthiaskrgr commented Nov 6, 2025

mmh getting weird test failures
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 6, 2025
@GuillaumeGomez
Rollup merge of rust-lang#148556 - chenyukang:yukang-fix-148493-async…
9fab8c5 
…-closure, r=JonathanBrouwer Fix suggestion for returning async closures Fixes rust-lang#148493
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 6, 2025
@GuillaumeGomez
Rollup merge of rust-lang#148561 - chenyukang:yukang-fix-148488, r=lqd
b9c8b5b 
Fix ICE from async closure variance Fixes rust-lang#148488 The fix is also a change from rust-lang#148556
@GuillaumeGomez GuillaumeGomez mentioned this pull request Nov 6, 2025
Closed
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Nov 6, 2025

Looks like this does soft-conflict with #148561
Let's have that one go first then
@bors r-
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 6, 2025
rust-timer added a commit that referenced this pull request Nov 6, 2025
@rust-timer
Unrolled build for #148561
5436bb3 
Rollup merge of #148561 - chenyukang:yukang-fix-148488, r=lqd Fix ICE from async closure variance Fixes #148488 The fix is also a change from #148556
@JonathanBrouwer
Copy link
Contributor

JonathanBrouwer commented Nov 6, 2025

@chenyukang Could you rebase? Then I'll reapprove
@chenyukang chenyukang force-pushed the yukang-fix-148493-async-closure branch from 702bf00 to 2dfe4f4 Compare November 6, 2025 23:11
@rustbot
Copy link
Collaborator

rustbot commented Nov 6, 2025

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.
@chenyukang
Copy link
Member Author

chenyukang commented Nov 6, 2025

@chenyukang Could you rebase? Then I'll reapprove

rebased, thanks.
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@chenyukang chenyukang force-pushed the yukang-fix-148493-async-closure branch from 2dfe4f4 to c92ef47 Compare November 7, 2025 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

6 participants

@chenyukang @rustbot @JonathanBrouwer @bors @matthiaskrgr @rust-log-analyzer