-   Notifications  You must be signed in to change notification settings 
- Fork 13.9k
 Remove QPath::LangItem #148193 
 New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
  Remove QPath::LangItem  #148193 
  Conversation
Get ready to incrementally remove LangItem::QPath.
   This comment has been minimized. 
   
 This comment has been minimized.
15e47d8 to 0d5c875   Compare      This comment has been minimized. 
   
 This comment has been minimized.
0d5c875 to 95732f4   Compare   | Thanks for the very clean PR! | 
…r=cjgillot Remove `QPath::LangItem` Closes rust-lang#115178. r? cjgillot
Rollup of 9 pull requests Successful merges: - #138217 (Turn `Cow::is_borrowed,is_owned` into associated functions.) - #147858 (Micro-optimization attempt in coroutine layout computation) - #147923 (Simplify rustc_public context handling) - #147935 (Add LLVM realtime sanitizer) - #148115 (rustdoc: Rename unstable option `--nocapture` to `--no-capture` in accordance with `libtest`) - #148137 (Couple of changes for Redox OS) - #148176 ([rustdoc] Include attribute and derive macros when filtering on "macros") - #148193 (Remove `QPath::LangItem`) - #148253 (Handle default features and -Ctarget-features in the dummy backend) r? `@ghost` `@rustbot` modify labels: rollup
| ☀️ Test successful - checks-actions | 
| What is this?This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.Comparing 72fe2ff (parent) -> 6906167 (this PR) Test differencesShow 80 test diffs80 doctest diffs were found. These are ignored, as they are noisy. Test dashboardRun cargo run --manifest-path src/ci/citool/Cargo.toml -- \ test-dashboard 6906167e01fba6f702f123264653f8e401546731 --output-dir test-dashboardAnd then open  Job duration changes
 How to interpret the job duration changes?Job durations can vary a lot, based on the actual runner instance | 
| Finished benchmarking commit (6906167): comparison URL. Overall result: ❌✅ regressions and improvements - please read the text belowOur benchmarks found a performance regression caused by this PR. Next Steps: 
 @rustbot label: +perf-regression Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy. 
 Max RSS (memory usage)Results (primary 0.9%, secondary 1.5%)A less reliable metric. May be of interest, but not used to determine the overall result above. 
 CyclesResults (primary 3.8%, secondary 2.2%)A less reliable metric. May be of interest, but not used to determine the overall result above. 
 Binary sizeResults (primary 1.1%, secondary -0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above. 
 Bootstrap: 475.302s -> 475.565s (0.06%) | 
Closes #115178.
r? cjgillot