split definition and use site hidden tys #148170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Some changes occurred in exhaustiveness checking cc @Nadrieril |
rustbot added S-waiting-on-review 
lcnr commented Oct 27, 2025
Comment on lines -553 to -555
| for hidden_ty in fcx_typeck_results.hidden_types.values() { | ||
| assert!(!hidden_ty.has_infer()); | ||
| } |
There was a problem hiding this comment.
ideally this is just an assert in EarlyBinder::bind. Adding that is more annoying than I expected as we need to do some lifetime dependent shit in some of the query system stuff which relies on transmutes. nm, actually just gonna do that in this PR as well
There was a problem hiding this comment.
also ass because we create ty::EarlyBinder<'tcx, impl IntoIterator<Item = ty::Binder<'tcx, ty::TraitRef<'tcx>>>> sometimes. An early binder of an iterator :x
| ☔ The latest upstream changes (presumably #148220) made this pull request unmergeable. Please resolve the merge conflicts. |
lcnr force-pushed the opaques-early-binder branch from cd5dc48 to 3a6ab3f Compare This comment has been minimized.
This comment has been minimized.
BoxyUwU reviewed Oct 31, 2025
Comment on lines +824 to +828
| let ty = match defining_scope_kind { | ||
| DefiningScopeKind::HirTypeck => { | ||
| fold_regions(tcx, self.ty, |_, _| tcx.lifetimes.re_erased) | ||
| } | ||
| DefiningScopeKind::MirBorrowck => self.ty, |
There was a problem hiding this comment.
rustfmt went out of its way to make a match arm bigger just because it had more space? wut
| location_map: Rc<DenseLocationMap>, | ||
| hidden_types: &mut DefinitionSiteHiddenTypes<'tcx>, | ||
| hidden_types: &mut FxIndexMap<LocalDefId, ty::DefinitionSiteHiddenType<'tcx>>, | ||
| opaque_types: &[(OpaqueTypeKey<'tcx>, OpaqueHiddenType<'tcx>)], |
There was a problem hiding this comment.
should rename OpaqueHiddenType to ProvisionHiddenType so that its always clear that there are two "kinds" of hidden types.
BoxyUwU added S-waiting-on-author lcnr force-pushed the opaques-early-binder branch from 3a6ab3f to 5cbb5d0 Compare | This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
| @bors r+ |
bors added S-waiting-on-bors bors added a commit that referenced this pull request Nov 2, 2025
split definition and use site hidden tys Tracking this implicitly is kinda messy and easy to get wrong. r? `@BoxyUwU`
| 💔 Test failed - checks-actions |
bors added S-waiting-on-review 
| Looks like a CI runner flaked out. @bors retry |
bors added S-waiting-on-bors bors added a commit that referenced this pull request Nov 2, 2025
split definition and use site hidden tys Tracking this implicitly is kinda messy and easy to get wrong. r? `@BoxyUwU`
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 2, 2025
split definition and use site hidden tys Tracking this implicitly is kinda messy and easy to get wrong. r? `@BoxyUwU`
| Yielding to enclosing rollup. @bors retry |
bors added a commit that referenced this pull request Nov 2, 2025
Rollup of 9 pull requests Successful merges: - #147947 (Implement `strip_circumfix` lib feature) - #148170 (split definition and use site hidden tys) - #148194 (compiletest: Remove `cleanup_debug_info_options`) - #148199 (compiletest: Don't modify `testpaths` when creating aux contexts) - #148240 (rustc_codegen: fix musttail returns for cast/indirect ABIs) - #148290 (Do not emit solver errors that contain error types) - #148357 (temporary-lifetime-extension.rs test works in all editions) - #148362 (docs: makes a note about possible building `rustc 1.91.0 + host tools` for win7) - #148367 (Use --print host-tuple to get the host) r? `@ghost` `@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 2, 2025
split definition and use site hidden tys Tracking this implicitly is kinda messy and easy to get wrong. r? `@BoxyUwU`
This was referenced Nov 2, 2025
bors added a commit that referenced this pull request Nov 2, 2025
Rollup of 8 pull requests Successful merges: - #148170 (split definition and use site hidden tys) - #148194 (compiletest: Remove `cleanup_debug_info_options`) - #148199 (compiletest: Don't modify `testpaths` when creating aux contexts) - #148290 (Do not emit solver errors that contain error types) - #148357 (temporary-lifetime-extension.rs test works in all editions) - #148362 (docs: makes a note about possible building `rustc 1.91.0 + host tools` for win7) - #148367 (Use --print host-tuple to get the host) - #148374 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer added a commit that referenced this pull request Nov 2, 2025
Rollup merge of #148170 - lcnr:opaques-early-binder, r=BoxyUwU split definition and use site hidden tys Tracking this implicitly is kinda messy and easy to get wrong. r? ``@BoxyUwU``
github-actions bot pushed a commit to rust-lang/miri that referenced this pull request Nov 3, 2025
Rollup of 8 pull requests Successful merges: - rust-lang/rust#148170 (split definition and use site hidden tys) - rust-lang/rust#148194 (compiletest: Remove `cleanup_debug_info_options`) - rust-lang/rust#148199 (compiletest: Don't modify `testpaths` when creating aux contexts) - rust-lang/rust#148290 (Do not emit solver errors that contain error types) - rust-lang/rust#148357 (temporary-lifetime-extension.rs test works in all editions) - rust-lang/rust#148362 (docs: makes a note about possible building `rustc 1.91.0 + host tools` for win7) - rust-lang/rust#148367 (Use --print host-tuple to get the host) - rust-lang/rust#148374 (miri subtree update) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Tracking this implicitly is kinda messy and easy to get wrong.
r? @BoxyUwU