Skip to content

ci: loongarch64: use medium code model to avoid relocation overflows #148158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 28, 2025
Merged

ci: loongarch64: use medium code model to avoid relocation overflows #148158

merged 1 commit into from
Oct 28, 2025
+6 −2

Conversation

@heiher
Copy link
Contributor

@heiher heiher commented Oct 27, 2025

The LoongArch C/C++ cross toolchain defaults to the normal code model, which can cause relocation overflows when linking LLVM after upgrading to verion 22. This change uses the mediumcode model for loongarch64-linux-gnu and loongarch64-linux-musl builds to avoid these linking errors.
@heiher
ci: loongarch64: use medium code model to avoid relocation overflows
87c66c9 
The LoongArch C/C++ cross toolchain defaults to the `normal` code model, which can cause relocation overflows when linking LLVM after upgrading to verion 22. This change uses the `medium`code model for `loongarch64-linux-gnu` and `loongarch64-linux-musl` builds to avoid these linking errors.
@rustbot rustbot added A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Oct 27, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 27, 2025

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
jieyouxu
jieyouxu approved these changes Oct 27, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

View changes since this review
@jieyouxu jieyouxu added the O-loongarch Target: LoongArch (LA32R, LA32S, LA64) label Oct 27, 2025
@jieyouxu
Copy link
Member

jieyouxu commented Oct 27, 2025

@bors r+
@bors
Copy link
Collaborator

bors commented Oct 27, 2025

📌 Commit 87c66c9 has been approved by jieyouxu

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 27, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 27, 2025
@matthiaskrgr
Rollup merge of rust-lang#148158 - heiher:loong64-medium, r=jieyouxu
2a55cec 
ci: loongarch64: use medium code model to avoid relocation overflows The LoongArch C/C++ cross toolchain defaults to the `normal` code model, which can cause relocation overflows when linking LLVM after upgrading to verion 22. This change uses the `medium`code model for `loongarch64-linux-gnu` and `loongarch64-linux-musl` builds to avoid these linking errors.
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 27, 2025
Closed
bors added a commit that referenced this pull request Oct 28, 2025
@bors
Auto merge of #148178 - matthiaskrgr:rollup-yy0swwt, r=matthiaskrgr
c829707 
Rollup of 6 pull requests Successful merges: - #147840 (Rework unsizing coercions in the new solver) - #148139 (Add `coverage` scope for controlling paths in code coverage) - #148154 (Add a mailmap entry) - #148158 (ci: loongarch64: use medium code model to avoid relocation overflows) - #148172 (rustc-dev-guide subtree update) - #148175 (Fix typos: duplicate words in comments) r? `@ghost` `@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 28, 2025
@Zalathar
Rollup merge of rust-lang#148158 - heiher:loong64-medium, r=jieyouxu
806e49f 
ci: loongarch64: use medium code model to avoid relocation overflows The LoongArch C/C++ cross toolchain defaults to the `normal` code model, which can cause relocation overflows when linking LLVM after upgrading to verion 22. This change uses the `medium`code model for `loongarch64-linux-gnu` and `loongarch64-linux-musl` builds to avoid these linking errors.
This was referenced Oct 28, 2025
Closed
Merged
bors added a commit that referenced this pull request Oct 28, 2025
@bors
Auto merge of #148202 - Zalathar:rollup-2eriuc3, r=Zalathar
c9537a9 
Rollup of 14 pull requests Successful merges: - #144936 (CFI: Fix types that implement Fn, FnMut, or FnOnce) - #147185 (repr(transparent): do not consider repr(C) types to be 1-ZST) - #147840 (Rework unsizing coercions in the new solver) - #147915 (Update target maintainers android.md) - #148013 (1.91.0 release notes) - #148044 (compiletest: show output in debug logging) - #148057 (tests/ui/sanitizer/hwaddress.rs: Run on aarch64 and remove cgu hack) - #148139 (Add `coverage` scope for controlling paths in code coverage) - #148154 (Add a mailmap entry) - #148158 (ci: loongarch64: use medium code model to avoid relocation overflows) - #148166 (Re-enable macro-stepping test for AArch64) - #148172 (rustc-dev-guide subtree update) - #148175 (Fix typos: duplicate words in comments) - #148186 (rustdoc-search: add an integration test for CCI) Failed merges: - #147935 (Add LLVM realtime sanitizer) r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit d02848e into rust-lang:master Oct 28, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Oct 28, 2025
rust-timer added a commit that referenced this pull request Oct 28, 2025
@rust-timer
Unrolled build for #148158
fd7f9cb 
Rollup merge of #148158 - heiher:loong64-medium, r=jieyouxu ci: loongarch64: use medium code model to avoid relocation overflows The LoongArch C/C++ cross toolchain defaults to the `normal` code model, which can cause relocation overflows when linking LLVM after upgrading to verion 22. This change uses the `medium`code model for `loongarch64-linux-gnu` and `loongarch64-linux-musl` builds to avoid these linking errors.
bors added a commit that referenced this pull request Oct 28, 2025
@bors
Auto merge of #148178 - matthiaskrgr:rollup-yy0swwt, r=matthiaskrgr
e964b00 
Rollup of 6 pull requests Successful merges: - #147840 (Rework unsizing coercions in the new solver) - #148139 (Add `coverage` scope for controlling paths in code coverage) - #148154 (Add a mailmap entry) - #148158 (ci: loongarch64: use medium code model to avoid relocation overflows) - #148172 (rustc-dev-guide subtree update) - #148175 (Fix typos: duplicate words in comments) r? `@ghost` `@rustbot` modify labels: rollup
@Zalathar
Copy link
Member

Zalathar commented Oct 28, 2025

In the rollup that merged this PR, the dist-loongarch64 jobs appear to have taken more than twice as long as usual, jumping from ~1.5 hours to over 3 hours: #148202 (comment)

Could be a fluke; could be something to keep an eye on.
@heiher
Copy link
Contributor Author

heiher commented Oct 28, 2025

In the rollup that merged this PR, the dist-loongarch64 jobs appear to have taken more than twice as long as usual, jumping from ~1.5 hours to over 3 hours: #148202 (comment)

Could be a fluke; could be something to keep an eye on.

I think this is expected. This patch invalidates the scache, but the cache hits will return on the next build.
@heiher heiher deleted the loong64-medium branch October 28, 2025 13:33
github-actions bot pushed a commit to rust-lang/rustc-dev-guide that referenced this pull request Nov 3, 2025
@bors
Auto merge of #148202 - Zalathar:rollup-2eriuc3, r=Zalathar
8fa389b 
Rollup of 14 pull requests Successful merges: - rust-lang/rust#144936 (CFI: Fix types that implement Fn, FnMut, or FnOnce) - rust-lang/rust#147185 (repr(transparent): do not consider repr(C) types to be 1-ZST) - rust-lang/rust#147840 (Rework unsizing coercions in the new solver) - rust-lang/rust#147915 (Update target maintainers android.md) - rust-lang/rust#148013 (1.91.0 release notes) - rust-lang/rust#148044 (compiletest: show output in debug logging) - rust-lang/rust#148057 (tests/ui/sanitizer/hwaddress.rs: Run on aarch64 and remove cgu hack) - rust-lang/rust#148139 (Add `coverage` scope for controlling paths in code coverage) - rust-lang/rust#148154 (Add a mailmap entry) - rust-lang/rust#148158 (ci: loongarch64: use medium code model to avoid relocation overflows) - rust-lang/rust#148166 (Re-enable macro-stepping test for AArch64) - rust-lang/rust#148172 (rustc-dev-guide subtree update) - rust-lang/rust#148175 (Fix typos: duplicate words in comments) - rust-lang/rust#148186 (rustdoc-search: add an integration test for CCI) Failed merges: - rust-lang/rust#147935 (Add LLVM realtime sanitizer) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-CI Area: Our Github Actions CI A-testsuite Area: The testsuite used to check the correctness of rustc O-loongarch Target: LoongArch (LA32R, LA32S, LA64) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.

5 participants

@heiher @rustbot @jieyouxu @bors @Zalathar