Skip to content

cg_llvm: Pass debuginfo_compression through FFI as an enum #148103

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2025
Merged

cg_llvm: Pass debuginfo_compression through FFI as an enum #148103

merged 1 commit into from
Nov 1, 2025
+60 −42

Conversation

@Zalathar
Copy link
Member

@Zalathar Zalathar commented Oct 25, 2025

There are only three possible values, making an enum more appropriate.

This avoids string allocation on the Rust side, and avoids ad-hoc !strcmp to convert back to an enum on the C++ side.
@rustbot rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label Oct 25, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 25, 2025

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 25, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@wesleywiser
Copy link
Member

wesleywiser commented Oct 31, 2025

@bors r+
@bors
Copy link
Collaborator

bors commented Oct 31, 2025

📌 Commit 73b734b has been approved by wesleywiser

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 31, 2025
@matthiaskrgr matthiaskrgr mentioned this pull request Oct 31, 2025
Merged
bors added a commit that referenced this pull request Oct 31, 2025
@bors
Auto merge of #148337 - matthiaskrgr:rollup-vojwz0m, r=matthiaskrgr
bada951 
Rollup of 9 pull requests Successful merges: - #139310 (add first HelenOS compilation targets) - #147161 (implement VecDeque extend_from_within and prepend_from_within) - #147622 (`unicode_data` refactors) - #147780 (Implement VecDeque::extract_if) - #147942 (Enable regression labeling aliases) - #147986 (Use fstatat() in DirEntry::metadata on Apple platforms) - #148103 (cg_llvm: Pass `debuginfo_compression` through FFI as an enum) - #148319 (docs: Fix argument names for `carrying_mul_add`) - #148322 (Enable file locking support in illumos) r? `@ghost` `@rustbot` modify labels: rollup
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025
@Zalathar
Rollup merge of rust-lang#148103 - Zalathar:compression, r=wesleywiser
841549f 
cg_llvm: Pass `debuginfo_compression` through FFI as an enum There are only three possible values, making an enum more appropriate. This avoids string allocation on the Rust side, and avoids ad-hoc `!strcmp` to convert back to an enum on the C++ side.
@Zalathar Zalathar mentioned this pull request Nov 1, 2025
Closed
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025
@Zalathar
Rollup merge of rust-lang#148103 - Zalathar:compression, r=wesleywiser
fd218ee 
cg_llvm: Pass `debuginfo_compression` through FFI as an enum There are only three possible values, making an enum more appropriate. This avoids string allocation on the Rust side, and avoids ad-hoc `!strcmp` to convert back to an enum on the C++ side.
@Zalathar Zalathar mentioned this pull request Nov 1, 2025
Closed
bors added a commit that referenced this pull request Nov 1, 2025
@bors
Auto merge of #148337 - matthiaskrgr:rollup-vojwz0m, r=matthiaskrgr
d85276b 
Rollup of 9 pull requests Successful merges: - #139310 (add first HelenOS compilation targets) - #147161 (implement VecDeque extend_from_within and prepend_from_within) - #147622 (`unicode_data` refactors) - #147780 (Implement VecDeque::extract_if) - #147942 (Enable regression labeling aliases) - #147986 (Use fstatat() in DirEntry::metadata on Apple platforms) - #148103 (cg_llvm: Pass `debuginfo_compression` through FFI as an enum) - #148319 (docs: Fix argument names for `carrying_mul_add`) - #148322 (Enable file locking support in illumos) r? `@ghost` `@rustbot` modify labels: rollup
@bors bors merged commit 3d671c0 into rust-lang:master Nov 1, 2025
11 checks passed
@rustbot rustbot added this to the 1.93.0 milestone Nov 1, 2025
rust-timer added a commit that referenced this pull request Nov 1, 2025
@rust-timer
Unrolled build for #148103
d6b0e6e 
Rollup merge of #148103 - Zalathar:compression, r=wesleywiser cg_llvm: Pass `debuginfo_compression` through FFI as an enum There are only three possible values, making an enum more appropriate. This avoids string allocation on the Rust side, and avoids ad-hoc `!strcmp` to convert back to an enum on the C++ side.
@Zalathar Zalathar deleted the compression branch November 1, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

6 participants

@Zalathar @rustbot @rust-log-analyzer @wesleywiser @bors @davidtwco