Fix invalid jump to def link generated on derive attributes #147990
Merged
+4 −2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added S-waiting-on-review 
GuillaumeGomez force-pushed the fix-derive-link branch from 9e7076b to 21db004 Compare 
| @bors r+ rollup |
bors added S-waiting-on-bors 
bors added a commit that referenced this pull request Oct 22, 2025
Rollup of 5 pull requests Successful merges: - #145617 (docs(style): Specify the frontmatter style) - #147830 (Reword unstable fingerprints ICE to ask for reproduction) - #147988 (Remove unused field `style` from `AttributeKind::CrateName`) - #147990 (Fix invalid jump to def link generated on derive attributes) - #147991 ([rustdoc] Check `doc(cfg())` even of private/hidden items) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #147820.
The issue was that we only handled bang macros whereas we should handle all of them.
r? @notriddle