Skip to content

Update list of available search filters in help menu #147909

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
GuillaumeGomez wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Update list of available search filters in help menu #147909

GuillaumeGomez wants to merge 1 commit into from
+12 −3

Conversation

@GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Oct 20, 2025

Just realized that the help menu mentions the list of available search item type filters... but it's also very incomplete and the book says the full list is provided there.

Considering that search.js is supposed to be self-contained (for our testsuite mostly) and that we don't want to add an extra step to generate JS (so we can copy-paste it around and just test it), I'm not too sure what would be the best solution here.

Anyway, question for future us, in the meantime, this adds the missing entries in the help menu:

image

r? @lolbinarycat
@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2025

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez, @jsha, @lolbinarycat
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Oct 20, 2025
@rustbot rustbot added the T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. label Oct 20, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Oct 24, 2025

r? @notriddle
@rustbot rustbot assigned notriddle and unassigned lolbinarycat Oct 24, 2025
@notriddle
Copy link
Contributor

notriddle commented Oct 24, 2025

Ick, no. That is way too long for a flat list like that. Maybe, instead?

Accepted kinds are:

  • struct, enum, union
  • structfield, variant
  • type: primitive, associatedtype
  • constant: associatedconstant
  • fn: method, tymethod
  • trait: traitalias
  • macro: attr, derive (NOTE: typePassesFilter doesn't implement this, but it should)
  • import: externcrate (NOTE: typePassesFilter doesn't implement this, but it should)
  • keyword, attribute
  • mod
  • static
  • foreigntype
  • generic

existential and impl exist in the code, but are anonymous, so you can't actually use them.
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Oct 27, 2025

I wanted something similar originally but that would make it too "tall". Gonna need to think how to present that in a better shape without taking too much height.
@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 27, 2025
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 29, 2025
@matthiaskrgr
Rollup merge of rust-lang#148176 - GuillaumeGomez:filter-macros, r=no…
f1c5ebe 
…triddle [rustdoc] Include attribute and derive macros when filtering on "macros" As discussed [here](rust-lang#147909), some filters should have been "grouped". This PR allows attribute and derive macros to match the `macro` filter. I'll wait for rust-lang#148005 to add more tests as it would require a proc-macro library for now. r? `@notriddle`
Zalathar added a commit to Zalathar/rust that referenced this pull request Oct 30, 2025
@Zalathar
Rollup merge of rust-lang#148176 - GuillaumeGomez:filter-macros, r=no…
8965a90 
…triddle [rustdoc] Include attribute and derive macros when filtering on "macros" As discussed [here](rust-lang#147909), some filters should have been "grouped". This PR allows attribute and derive macros to match the `macro` filter. I'll wait for rust-lang#148005 to add more tests as it would require a proc-macro library for now. r? ``@notriddle``
jhpratt added a commit to jhpratt/rust that referenced this pull request Oct 30, 2025
@jhpratt
Rollup merge of rust-lang#148176 - GuillaumeGomez:filter-macros, r=no…
645e41a 
…triddle [rustdoc] Include attribute and derive macros when filtering on "macros" As discussed [here](rust-lang#147909), some filters should have been "grouped". This PR allows attribute and derive macros to match the `macro` filter. I'll wait for rust-lang#148005 to add more tests as it would require a proc-macro library for now. r? ```@notriddle```
rust-timer added a commit that referenced this pull request Oct 30, 2025
@rust-timer
Unrolled build for #148176
1c09b0c 
Rollup merge of #148176 - GuillaumeGomez:filter-macros, r=notriddle [rustdoc] Include attribute and derive macros when filtering on "macros" As discussed [here](#147909), some filters should have been "grouped". This PR allows attribute and derive macros to match the `macro` filter. I'll wait for #148005 to add more tests as it would require a proc-macro library for now. r? ```@notriddle```
@GuillaumeGomez GuillaumeGomez mentioned this pull request Oct 30, 2025
Merged
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025
@Zalathar
Rollup merge of rust-lang#148301 - GuillaumeGomez:import-filter, r=no…
707c075 
…triddle [rustdoc search] Include extern crates when filtering on `import` As discussed rust-lang#147909, some filters should have been "grouped". This PR allows extern crates to match the `import` filter. This PR also allowed me to uncover a bug for the URL generated for renamed extern crates. Opened rust-lang#148300 for it. r? `@notriddle`
Zalathar added a commit to Zalathar/rust that referenced this pull request Nov 1, 2025
@Zalathar
Rollup merge of rust-lang#148301 - GuillaumeGomez:import-filter, r=no…
e1539af 
…triddle [rustdoc search] Include extern crates when filtering on `import` As discussed rust-lang#147909, some filters should have been "grouped". This PR allows extern crates to match the `import` filter. This PR also allowed me to uncover a bug for the URL generated for renamed extern crates. Opened rust-lang#148300 for it. r? ``@notriddle``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 1, 2025
@matthiaskrgr
Rollup merge of rust-lang#148301 - GuillaumeGomez:import-filter, r=no…
e6edc6d 
…triddle [rustdoc search] Include extern crates when filtering on `import` As discussed rust-lang#147909, some filters should have been "grouped". This PR allows extern crates to match the `import` filter. This PR also allowed me to uncover a bug for the URL generated for renamed extern crates. Opened rust-lang#148300 for it. r? ```@notriddle```
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 1, 2025
@matthiaskrgr
Rollup merge of rust-lang#148301 - GuillaumeGomez:import-filter, r=no…
43eeea7 
…triddle [rustdoc search] Include extern crates when filtering on `import` As discussed rust-lang#147909, some filters should have been "grouped". This PR allows extern crates to match the `import` filter. This PR also allowed me to uncover a bug for the URL generated for renamed extern crates. Opened rust-lang#148300 for it. r? ````@notriddle````
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 1, 2025
@matthiaskrgr
Rollup merge of rust-lang#148301 - GuillaumeGomez:import-filter, r=no…
e809645 
…triddle [rustdoc search] Include extern crates when filtering on `import` As discussed rust-lang#147909, some filters should have been "grouped". This PR allows extern crates to match the `import` filter. This PR also allowed me to uncover a bug for the URL generated for renamed extern crates. Opened rust-lang#148300 for it. r? `````@notriddle`````
rust-timer added a commit that referenced this pull request Nov 1, 2025
@rust-timer
Unrolled build for #148301
ca17abf 
Rollup merge of #148301 - GuillaumeGomez:import-filter, r=notriddle [rustdoc search] Include extern crates when filtering on `import` As discussed #147909, some filters should have been "grouped". This PR allows extern crates to match the `import` filter. This PR also allowed me to uncover a bug for the URL generated for renamed extern crates. Opened #148300 for it. r? `````@notriddle`````
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Nov 4, 2025
@jhpratt
Rollup merge of #148176 - GuillaumeGomez:filter-macros, r=notriddle
d50518f 
[rustdoc] Include attribute and derive macros when filtering on "macros" As discussed [here](rust-lang/rust#147909), some filters should have been "grouped". This PR allows attribute and derive macros to match the `macro` filter. I'll wait for rust-lang/rust#148005 to add more tests as it would require a proc-macro library for now. r? ```@notriddle```
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 8, 2025
@jhpratt
Rollup merge of rust-lang#148176 - GuillaumeGomez:filter-macros, r=no…
93a4310 
…triddle [rustdoc] Include attribute and derive macros when filtering on "macros" As discussed [here](rust-lang#147909), some filters should have been "grouped". This PR allows attribute and derive macros to match the `macro` filter. I'll wait for rust-lang#148005 to add more tests as it would require a proc-macro library for now. r? ```@notriddle```
makai410 pushed a commit to makai410/rust that referenced this pull request Nov 10, 2025
@jhpratt
Rollup merge of rust-lang#148176 - GuillaumeGomez:filter-macros, r=no…
a9ee6f6 
…triddle [rustdoc] Include attribute and derive macros when filtering on "macros" As discussed [here](rust-lang#147909), some filters should have been "grouped". This PR allows attribute and derive macros to match the `macro` filter. I'll wait for rust-lang#148005 to add more tests as it would require a proc-macro library for now. r? ```@notriddle```
makai410 pushed a commit to makai410/rustc_public that referenced this pull request Nov 16, 2025
@jhpratt
Rollup merge of #148176 - GuillaumeGomez:filter-macros, r=notriddle
3bd79c8 
[rustdoc] Include attribute and derive macros when filtering on "macros" As discussed [here](rust-lang/rust#147909), some filters should have been "grouped". This PR allows attribute and derive macros to match the `macro` filter. I'll wait for rust-lang/rust#148005 to add more tests as it would require a proc-macro library for now. r? ```@notriddle```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output.

5 participants

@GuillaumeGomez @rustbot @rust-log-analyzer @notriddle @lolbinarycat