Skip to content

Do not enable LLD if we don't build host code for targets that opt into it #147698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Do not enable LLD if we don't build host code for targets that opt into it #147698

wants to merge 1 commit into from

Conversation

Kobzol
Copy link
Member

@Kobzol Kobzol commented Oct 14, 2025

Should fix the problem mentioned in #147626 (comment).

r? @jieyouxu
@rustbot
Copy link
Collaborator

rustbot commented Oct 14, 2025

This PR modifies src/bootstrap/src/core/config.

If appropriate, please update CONFIG_CHANGE_HISTORY in src/bootstrap/src/utils/change_tracker.rs.
@rustbot rustbot added A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Oct 14, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 14, 2025

jieyouxu is not on the review rotation at the moment.
They may take a while to respond.
@rustbot

This comment was marked as outdated.

Sign in to view
@Kobzol Kobzol mentioned this pull request Oct 14, 2025
Merged
jieyouxu
jieyouxu approved these changes Oct 15, 2025
View reviewed changes
Copy link
Member

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do wonder if we should eventually transition to

we could also make the LLD config per-target, but that would complicate things

but this seems very reasonable in the meantime, thanks.

View changes since this review
@jieyouxu
Copy link
Member

@bors r+ rollup=never
@bors
Copy link
Collaborator

bors commented Oct 15, 2025

📌 Commit a2c7e17 has been approved by jieyouxu

It is now in the queue for this repository.
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2025
@dpaoliello
Copy link
Contributor

Validated that this change fixes the issue in our Arm64EC validation pipeline: we no longer need to set rust.lld=false.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

5 participants

@Kobzol @rustbot @jieyouxu @bors @dpaoliello