Simplify trivial constants in SimplifyConstCondition #147654
Conversation
rustbot added S-waiting-on-author 
| @bors try @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Simplify trivial constants in SimplifyConstCondition
rustbot added the S-waiting-on-perf This comment has been minimized.
This comment has been minimized.
| Finished benchmarking commit (2d02757): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.7%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 3.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 475.312s -> 475.552s (0.05%) |
rustbot removed the S-waiting-on-perf 
dianqk force-pushed the simplify-const-condition branch from 3877315 to dcd9af0 Compare | @bors2 try parent=last @rust-timer queue |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Simplify trivial constants in SimplifyConstCondition
rustbot added the S-waiting-on-perf 
| Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
rustbot added S-waiting-on-review | r? @davidtwco rustbot has assigned @davidtwco. Use |
This comment has been minimized.
This comment has been minimized.
| Finished benchmarking commit (2b77d79): comparison URL. Overall result: ✅ improvements - no action neededBenchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf. @bors rollup=never Instruction countOur most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.
Max RSS (memory usage)Results (primary 0.9%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesResults (secondary 3.5%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Binary sizeResults (primary 0.0%, secondary 0.0%)A less reliable metric. May be of interest, but not used to determine the overall result above.
Bootstrap: 475.312s -> 474.926s (-0.08%) |
rustbot removed the S-waiting-on-perf 
| // optimizations. This invalidates CFG caches, so avoid putting between | ||
| // `ReferencePropagation` and `GVN` which both use the dominator tree. | ||
| &instsimplify::InstSimplify::AfterSimplifyCfg, | ||
| &o1(simplify_branches::SimplifyConstCondition::AfterInstSimplify), |
There was a problem hiding this comment.
Could you add a comment to explain why you put this pass here?
dianqk force-pushed the simplify-const-condition branch from bdc9444 to 0db7401 Compare | This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
dianqk force-pushed the simplify-const-condition branch from 0db7401 to 909fbcb Compare | | TerminatorKind::UnwindTerminate(_) | ||
| | TerminatorKind::Return | ||
| | TerminatorKind::Assert { .. } | ||
| | TerminatorKind::Yield { .. } |
There was a problem hiding this comment.
Yield writes to the resume_arg place.
dianqk force-pushed the simplify-const-condition branch from 909fbcb to 7af5775 Compare 
| @bors r+ |
bors added S-waiting-on-bors Simplify trivial constants in SimplifyConstCondition After `InstSimplify-after-simplifycfg` with `-Zub_checks=false`, there are many of the following patterns. ``` _13 = const false; assume(copy _13); _12 = unreachable_unchecked::precondition_check() -> [return: bb1, unwind unreachable]; ``` Simplifying them to unreachable early should make CFG simpler.
| The job Click to see the possible cause of the failure (guessed by this bot) |
| 💔 Test failed - checks-actions |
bors added S-waiting-on-review 
| Probably a spurious failure. See https://rust-lang.zulipchat.com/#narrow/channel/242791-t-infra/topic/Repeated.20spurious.20failure.20of.20.60x86_64-mingw-1.60/with/545487472. @bors retry |
bors added S-waiting-on-bors Simplify trivial constants in SimplifyConstCondition After `InstSimplify-after-simplifycfg` with `-Zub_checks=false`, there are many of the following patterns. ``` _13 = const false; assume(copy _13); _12 = unreachable_unchecked::precondition_check() -> [return: bb1, unwind unreachable]; ``` Simplifying them to unreachable early should make CFG simpler.
| The job Click to see the possible cause of the failure (guessed by this bot) |
| 💔 Test failed - checks-actions |
bors added S-waiting-on-review | @bors retry |
bors added S-waiting-on-bors 8 participants
After
InstSimplify-after-simplifycfgwith-Zub_checks=false, there are many of the following patterns.Simplifying them to unreachable early should make CFG simpler.