Rollup of 6 pull requests #147492
Closed
Rollup of 6 pull requests #147492
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
They will be used in Clippy.
Added missing FIXME comments
This adds a test for the cold attribute to verify that it actually does something, and that it applies correctly in all the positions it is expected to work.
[rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition Fixes rust-lang#143009. Fixes rust-lang#143858. Since it includes fixes from rust-lang#143453, it's taking it over (commits 2, 3 and 4 are from rust-lang#143453). For `--no-run`, we forgot to check the "global" options in the 2024 edition, fixed in the first commit. For `should_panic` fix, the exit code check has been fixed. cc ``@TroyKomodo`` (thanks so much for providing such a complete test, made my life a lot easier!) r? ``@notriddle``
…d, r=joboet Add diagnostic items for `pub mod consts` of FP types They will be used in Clippy.
…=JonathanBrouwer Fix double warnings on `#[no_mangle]` Fixes 2 out of 3 cases in rust-lang#147417 The fix on closures removes the old error and marks closures as an error target. The fix on consts adds `AllowSilent` to to ignore a target, and uses the old error because that one has a nice suggestion. r? ``@jdonszelmann``
…ukang Add a test for the cold attribute This adds a test for the cold attribute to verify that it actually does something, and that it applies correctly in all the positions it is expected to work.
…miasko Do not invalidate CFG caches in CtfeLimit. This does not matter much, as no optimization pass runs after `CtfeLimit`, but I still find the code cleaner.
format: some small cleanup Some small cleanup and some additional comments I did while trying to understand this code.
rustbot added A-attributes Member Author
| @bors r+ rollup=never p=5 |
Collaborator
bors added S-waiting-on-bors Collaborator
bors added a commit that referenced this pull request Oct 8, 2025
Rollup of 6 pull requests Successful merges: - #143900 ([rustdoc] Correctly handle `should_panic` doctest attribute and fix `--no-run` test flag on the 2024 edition) - #147420 (Add diagnostic items for `pub mod consts` of FP types) - #147467 (Fix double warnings on `#[no_mangle]`) - #147476 (Add a test for the cold attribute) - #147480 (Do not invalidate CFG caches in CtfeLimit.) - #147481 (format: some small cleanup) r? `@ghost` `@rustbot` modify labels: rollup
Collaborator
| The job Click to see the possible cause of the failure (guessed by this bot) |
Collaborator
| 💔 Test failed - checks-actions |
bors added S-waiting-on-review 
Member
| @bors retry |
bors added S-waiting-on-bors Member
| em, it's failed for: #147492 (comment) pr: #147476 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Successful merges:
should_panicdoctest attribute and fix--no-runtest flag on the 2024 edition #143900 ([rustdoc] Correctly handleshould_panicdoctest attribute and fix--no-runtest flag on the 2024 edition)pub mod constsof FP types #147420 (Add diagnostic items forpub mod constsof FP types)#[no_mangle]#147467 (Fix double warnings on#[no_mangle])r? @ghost
@rustbot modify labels: rollup
Create a similar rollup