Rename "non-inline module" to "file module" in proc macro diagnostics #147438
+32 −32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added S-waiting-on-review 
| r? @fee1-dead rustbot has assigned @fee1-dead. Use |
This comment has been minimized.
This comment has been minimized.
reddevilmidzy force-pushed the rename-non-inline-module-in-msg branch from 9336dfa to 132efa7 Compare 
fee1-dead requested changes Oct 17, 2025
tests/ui/README.md Outdated
| ## `tests/ui/directory_ownership/`: Declaring `mod` inside a block | ||
| | ||
| Exercises diagnostics for when a code block attempts to gain ownership of a non-inline module with a `mod` keyword placed inside of it. | ||
| Exercises diagnostics for when a code block attempts to gain ownership of a file module with a `mod` keyword placed inside of it. |
There was a problem hiding this comment.
This is internal facing, so people reading it should probably have an idea of what a non-inline module means already.
The rest of the changes proposed here looks fine to me for diagnostics, but if we want to collectively rename (decide as a project what is the best name) it to "file module"s I feel like needs more discussion. So I propose reverting this change specifically in this file and I'd approve.
There was a problem hiding this comment.
Agreed, reverted the change as suggested!
rustbot added S-waiting-on-author 
reddevilmidzy force-pushed the rename-non-inline-module-in-msg branch from 132efa7 to a1a9113 Compare Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This PR updates diagnostic messages to use "file module" instead of "non-inline module". because the term "non-inline module" can be confusing, especially for non-native English speakers.
follow up PR #147395
related of #147314, #general > Rename "non-inline modules" to "external modules"
cc @Kivooeo