Skip to content

Conversation

bjoernager
Copy link
Contributor

@bjoernager bjoernager commented Oct 5, 2025

Tracking issue: #135758.

This PR adds the unchecked_disjoint_bitor method to additional types:

impl bool { pub const unsafe fn unchecked_disjoint_bitor(self, rhs: Self) -> Self; } impl i8 { pub const unsafe fn unchecked_disjoint_bitor(self, rhs: Self) -> Self; } impl i16 { pub const unsafe fn unchecked_disjoint_bitor(self, rhs: Self) -> Self; } impl i32 { pub const unsafe fn unchecked_disjoint_bitor(self, rhs: Self) -> Self; } impl i64 { pub const unsafe fn unchecked_disjoint_bitor(self, rhs: Self) -> Self; } impl i128 { pub const unsafe fn unchecked_disjoint_bitor(self, rhs: Self) -> Self; } impl isize { pub const unsafe fn unchecked_disjoint_bitor(self, rhs: Self) -> Self; }

Our disjoint_bitor intrinsic is already implemented for these types. This method specifically is also already present on unsigned, integral types.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 5, 2025
@rustbot
Copy link
Collaborator

rustbot commented Oct 5, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@bjoernager
Copy link
Contributor Author

@rustbot label +T-libs-api -T-libs

r? libs-api

@rustbot rustbot added T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Oct 5, 2025
@rustbot rustbot assigned BurntSushi and unassigned Mark-Simulacrum Oct 5, 2025
@rust-log-analyzer

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.

5 participants