Add proper error handling for closure in impl #147219
Merged
+32 −9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
rustbot added S-waiting-on-review 
| Maybe should have been a delayed bug? |
| You mean to just use |
rust-cloud-vms bot force-pushed the typeof-is-imposter branch from 4f8b62a to b810a68 Compare | Something like this? |
| this looks good, it goes from a guaranteed bug to a delayed bug so worst case it still causes an ICE somewhere in a place that before this change would already ICE. @bors r+ rollup |
bors added S-waiting-on-bors matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 1, 2025
…szelmann Add proper error handling for closure in impl Fixes rust-lang#147146 Fixes rust-lang#146620 Not sure if it can cause any regressions or anything, as for test also have no idea where to store this one cc `@theemathas` r? compiler
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 1, 2025
…szelmann Add proper error handling for closure in impl Fixes rust-lang#147146 Fixes rust-lang#146620 Not sure if it can cause any regressions or anything, as for test also have no idea where to store this one cc ``@theemathas`` r? compiler
This was referenced Oct 1, 2025
bors added a commit that referenced this pull request Oct 1, 2025
Rollup of 8 pull requests Successful merges: - #146593 (Allow specifying multiple bounds for same associated item, except in trait objects) - #147177 ([DebugInfo] Fix MSVC tuple child creation) - #147195 (iter repeat: add tests for new count and last behavior) - #147202 (Swap order of `resolve_coroutine_interiors` and `handle_opaque_type_uses`) - #147204 (Refactor ArrayWindows to use a slice) - #147219 (Add proper error handling for closure in impl) - #147226 (include `outer_inclusive_binder` of pattern types) - #147230 (Fix typo in 'unfulfilled_lint_expectation' to plural) r? `@ghost` `@rustbot` modify labels: rollup
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Oct 9, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#146593 (Allow specifying multiple bounds for same associated item, except in trait objects) - rust-lang#147177 ([DebugInfo] Fix MSVC tuple child creation) - rust-lang#147195 (iter repeat: add tests for new count and last behavior) - rust-lang#147202 (Swap order of `resolve_coroutine_interiors` and `handle_opaque_type_uses`) - rust-lang#147204 (Refactor ArrayWindows to use a slice) - rust-lang#147219 (Add proper error handling for closure in impl) - rust-lang#147226 (include `outer_inclusive_binder` of pattern types) - rust-lang#147230 (Fix typo in 'unfulfilled_lint_expectation' to plural) r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #147146
Fixes #146620
Not sure if it can cause any regressions or anything, as for test also have no idea where to store this one
cc @theemathas
r? compiler