mismatched_lifetime_syntax lint refactors and optimizations

[camsteffen]

I found several opportunities to return early so I'm hoping those will have a perf improvement. Otherwise, it's various refactors for simplicity.

[rustbot]

r? @fee1-dead

rustbot has assigned @fee1-dead.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

[jieyouxu]

@bors try @rust-timer queue

[rust-bors]

☀️ Try build successful (CI)
Build commit: 449ebb3 (449ebb32e12d5a3b8a3eff0898c5ebf9075fea63, parent: f6092f224d2b1774b31033f12d0bee626943b02f)

[rust-timer]

Finished benchmarking commit (449ebb3): comparison URL.

Overall result: ✅ improvements - no action needed

Benchmarking this pull request means it may be perf-sensitive – we'll automatically label it not fit for rolling up. You can override this, but we strongly advise not to, due to possible changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.2%]	5
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -1.7%, secondary 1.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	1.2%	[1.2%, 1.2%]	1
Improvements ✅ (primary)	-1.7%	[-2.3%, -0.9%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-1.7%	[-2.3%, -0.9%]	3

Cycles

Results (secondary -0.6%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.7%, 2.7%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.3%	[-2.6%, -2.0%]	2
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 471.715s -> 472.096s (0.08%)
Artifact size: 389.94 MiB -> 389.96 MiB (0.00%)

[mu001999]

LGTM

View changes since this review

[fee1-dead]

Thanks!
@bors r+

[bors]

📌 Commit c4074bd has been approved by fee1-dead

It is now in the queue for this repository.

[bors]

⌛ Testing commit c4074bd with merge db43546...

[bors]

💔 Test failed - checks-actions

[fee1-dead]

r=me after failure is fixed

[rustbot]

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

[camsteffen]

@rustbot ready

[rust-log-analyzer]

The job x86_64-gnu-tools failed! Check out the build log: (web) (plain enhanced) (plain)

Click to see the possible cause of the failure (guessed by this bot)

[WARNING] `tests/rustdoc-gui/search-result-display.goml` line 39: Delta is 0 for "x", maybe try to use `compare-elements-position` instead? ======== tests/rustdoc-gui/sidebar.goml ======== [ERROR] `tests/rustdoc-gui/sidebar.goml` line 247: TimeoutError: Timed out after waiting 30000ms: for command `assert-css: ("#rustdoc-toc", {"display": "block"})` [ERROR] `tests/rustdoc-gui/sidebar.goml` line 248: TimeoutError: Timed out after waiting 30000ms: for command `assert-css: (".sidebar .in-crate", {"display": "block"})` [ERROR] `tests/rustdoc-gui/sidebar.goml` line 250: TimeoutError: Timed out after waiting 30000ms: for command `set-local-storage: {"rustdoc-hide-modnav": "true"}` <= doc-ui tests done: 141 succeeded, 1 failed, 0 filtered out Error: () 

[camsteffen]

Looks like a flaky test. But I'm pretty sure this is ready @bors r=fee1-dead

[bors]

@camsteffen: 🔑 Insufficient privileges: Not in reviewers

[fee1-dead]

@bors r+

[bors]

📌 Commit f0eea4c has been approved by fee1-dead

It is now in the queue for this repository.

[bors]

⌛ Testing commit f0eea4c with merge 32892a3...

[bors]

☀️ Test successful - checks-actions
Approved by: fee1-dead
Pushing 32892a3 to master...

[github-actions]

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 2170b4d (parent) -> 32892a3 (this PR)

Test differences

Show 16 test diffs

16 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \ test-dashboard 32892a37b491e0bb8ffdf8aa6df14d3401c5684e --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

1. pr-check-1: 1756.7s -> 1424.0s (-18.9%)
2. aarch64-apple: 8256.0s -> 7153.9s (-13.3%)
3. i686-gnu-2: 6148.4s -> 5474.8s (-11.0%)
4. x86_64-gnu-gcc: 3389.2s -> 3062.7s (-9.6%)
5. x86_64-rust-for-linux: 2976.1s -> 2696.3s (-9.4%)
6. aarch64-gnu-debug: 4288.7s -> 3891.1s (-9.3%)
7. aarch64-gnu-llvm-20-1: 3606.0s -> 3299.7s (-8.5%)
8. test-various: 4860.6s -> 4503.5s (-7.3%)
9. x86_64-gnu-stable: 7581.3s -> 7034.6s (-7.2%)
10. armhf-gnu: 5270.2s -> 4913.0s (-6.8%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

[rust-timer]

Finished benchmarking commit (32892a3): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	0.1%	[0.1%, 0.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.3%, -0.1%]	4
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary -2.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.3%	[-2.3%, -2.2%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.3%	[-2.3%, -2.2%]	2

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 475.309s -> 475.327s (0.00%)
Artifact size: 390.33 MiB -> 390.40 MiB (0.02%)